From: Dan Carpenter <dan.carpenter@oracle.com> To: Chris Mason <clm@fb.com>, Nikolay Borisov <nborisov@suse.com> Cc: Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] btrfs: dereferencing error pointer in btrfs_quota_enable() Date: Thu, 2 Aug 2018 11:44:29 +0300 [thread overview] Message-ID: <20180802084428.k2uemow7k6j3us47@kili.mountain> (raw) The error handling in "goto out;" expects that if "trans" is non-NULL that means it's valid. Unfortunately it could also be an error pointer. Fixes: c9a6fe84fe43 ("btrfs: qgroups: Move transaction management inside btrfs_quota_enable/disable") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 3a9019928329..380ff978defa 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -904,6 +904,7 @@ int btrfs_quota_enable(struct btrfs_fs_info *fs_info) trans = btrfs_start_transaction(tree_root, 2); if (IS_ERR(trans)) { ret = PTR_ERR(trans); + trans = NULL; goto out; }
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Chris Mason <clm@fb.com>, Nikolay Borisov <nborisov@suse.com> Cc: Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] btrfs: dereferencing error pointer in btrfs_quota_enable() Date: Thu, 02 Aug 2018 08:44:29 +0000 [thread overview] Message-ID: <20180802084428.k2uemow7k6j3us47@kili.mountain> (raw) The error handling in "goto out;" expects that if "trans" is non-NULL that means it's valid. Unfortunately it could also be an error pointer. Fixes: c9a6fe84fe43 ("btrfs: qgroups: Move transaction management inside btrfs_quota_enable/disable") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 3a9019928329..380ff978defa 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -904,6 +904,7 @@ int btrfs_quota_enable(struct btrfs_fs_info *fs_info) trans = btrfs_start_transaction(tree_root, 2); if (IS_ERR(trans)) { ret = PTR_ERR(trans); + trans = NULL; goto out; }
next reply other threads:[~2018-08-02 10:34 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-02 8:44 Dan Carpenter [this message] 2018-08-02 8:44 ` [PATCH] btrfs: dereferencing error pointer in btrfs_quota_enable() Dan Carpenter 2018-08-02 10:22 ` Nikolay Borisov 2018-08-02 10:22 ` Nikolay Borisov 2018-08-02 13:34 ` David Sterba 2018-08-02 13:34 ` David Sterba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180802084428.k2uemow7k6j3us47@kili.mountain \ --to=dan.carpenter@oracle.com \ --cc=clm@fb.com \ --cc=dsterba@suse.com \ --cc=jbacik@fb.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=nborisov@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.