All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Mayhew <smayhew@redhat.com>
To: bfields@fieldses.org, jlayton@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] nfsd: ensure that writing '+4' to /proc/fs/nfsd/versions enables minor version 0
Date: Wed,  8 Aug 2018 07:36:00 -0400	[thread overview]
Message-ID: <20180808113600.11502-1-smayhew@redhat.com> (raw)

According to commit d3635ff07e8 ("nfsd: fix configuration of supported
minor versions"), it should be possible to use either '4.0' or '4' to
enable or disable minor version 0.

Currently, writing '+4' to /proc/fs/nfsd/versions has no effect unless
no minor versions are enabled.  That leaves rpc.nfsd without an easy
way to re-enable v4.0, since that's what it does when invoked with
'-V 4.0'.

Fixes: d3635ff07e8 ("nfsd: fix configuration of supported minor versions")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 fs/nfsd/nfsctl.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index d107b4426f7e..b3f9f9233953 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -614,6 +614,14 @@ static ssize_t __write_versions(struct file *file, char *buf, size_t size)
 					minor = 0;
 					while (nfsd_minorversion(minor, cmd) >= 0)
 						minor++;
+				} else if (cmd == NFSD_SET) {
+					/*
+					 * We have +4 but there are already some minors
+					 * enabled.  We must ensure 4.0 gets enabled,
+					 * since it could be a request from rpc.nfsd.
+					 */
+					if (nfsd_minorversion(0, cmd) < 0)
+						return -EINVAL;
 				}
 				break;
 			default:
-- 
2.14.4


             reply	other threads:[~2018-08-08 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 11:36 Scott Mayhew [this message]
2018-08-08 12:41 ` [PATCH] nfsd: ensure that writing '+4' to /proc/fs/nfsd/versions enables minor version 0 Trond Myklebust
2018-08-08 13:07   ` Scott Mayhew
2018-08-09 15:46     ` Scott Mayhew
2018-08-09 18:11       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808113600.11502-1-smayhew@redhat.com \
    --to=smayhew@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.