All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org, Coly Li <colyli@suse.de>
Subject: [PATCH 17/17] bcache: add the missing code comments for smp_mb()
Date: Thu,  9 Aug 2018 14:43:20 +0800	[thread overview]
Message-ID: <20180809064320.10229-18-colyli@suse.de> (raw)
In-Reply-To: <20180809064320.10229-1-colyli@suse.de>

Checkpatch.pl warns there are 2 locations of smp_mb() without code
comment. This patch adds the missing code comments for these smp_mb()
calls.

Signed-off-by: Coly Li <colyli@suse.de>
---
 drivers/md/bcache/closure.h | 4 +++-
 drivers/md/bcache/super.c   | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
index 7f3594c0be14..eca0d496b686 100644
--- a/drivers/md/bcache/closure.h
+++ b/drivers/md/bcache/closure.h
@@ -289,10 +289,12 @@ static inline void closure_init_stack(struct closure *cl)
 }
 
 /**
- * closure_wake_up - wake up all closures on a wait list.
+ * closure_wake_up - wake up all closures on a wait list,
+ *		     with memory barrier
  */
 static inline void closure_wake_up(struct closure_waitlist *list)
 {
+	/* Memory barrier for the wait list */
 	smp_mb();
 	__closure_wake_up(list);
 }
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index f8fe39c72f99..985e2f456081 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1136,11 +1136,11 @@ int bch_cached_dev_attach(struct cached_dev *dc, struct cache_set *c,
 	list_move(&dc->list, &c->cached_devs);
 	calc_cached_dev_sectors(c);
 
-	smp_wmb();
 	/*
 	 * dc->c must be set before dc->count != 0 - paired with the mb in
 	 * cached_dev_get()
 	 */
+	smp_wmb();
 	refcount_set(&dc->count, 1);
 
 	/* Block writeback thread, but spawn it */
-- 
2.18.0

      parent reply	other threads:[~2018-08-09  9:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  6:43 [PATCH 00/17] fixes reported by checkpatch.pl Coly Li
2018-08-09  6:43 ` [PATCH 01/17] bcache: style fix to replace 'unsigned' by 'unsigned int' Coly Li
2018-08-09  6:43 ` [PATCH 02/17] bcache: style fix to add a blank line after declarations Coly Li
2018-08-09  6:43 ` [PATCH 03/17] bcache: add identifier names to arguments of function definitions Coly Li
2018-08-09  6:43 ` [PATCH 04/17] bcache: style fixes for lines over 80 characters Coly Li
2018-08-09  6:43 ` [PATCH 05/17] bcache: replace Symbolic permissions by octal permission numbers Coly Li
2018-08-09  6:43 ` [PATCH 06/17] bcache: replace printk() by pr_*() routines Coly Li
2018-08-09  6:43 ` [PATCH 07/17] bcache: fix indent by replacing blank by tabs Coly Li
2018-08-09  6:43 ` [PATCH 08/17] bcache: replace '%pF' by '%pS' in seq_printf() Coly Li
2018-08-09  6:43 ` [PATCH 09/17] bcache: fix typo 'succesfully' to 'successfully' Coly Li
2018-08-09  6:43 ` [PATCH 10/17] bcache: prefer 'help' in Kconfig Coly Li
2018-08-09  6:43 ` [PATCH 11/17] bcache: do not check NULL pointer before calling kmem_cache_destroy Coly Li
2018-08-09  6:43 ` [PATCH 12/17] bcache: fix code comments style Coly Li
     [not found]   ` <44e430ab-36fd-caed-3d1b-65647fa9b42e@foxmail.com>
2018-08-10  6:55     ` Coly Li
2018-08-09  6:43 ` [PATCH 13/17] bcache: add static const prefix to char * array declarations Coly Li
2018-08-09  6:43 ` [PATCH 14/17] bcache: move open brace at end of function definitions to next line Coly Li
2018-08-09  6:43 ` [PATCH 15/17] bcache: add missing SPDX header Coly Li
2018-08-09  6:43 ` [PATCH 16/17] bcache: remove unnecessary space before ioctl function pointer arguments Coly Li
2018-08-09  6:43 ` Coly Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809064320.10229-18-colyli@suse.de \
    --to=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.