All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/i915/execlists: Refind the active request before resetting
Date: Tue, 14 Aug 2018 14:58:11 +0100	[thread overview]
Message-ID: <20180814135811.3300-2-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180814135811.3300-1-chris@chris-wilson.co.uk>

When resetting the context image after a GPU reset, it is vital that we
do inspect the context image that was active at the time of the hang.
Even a 'pardoned' context may still have some residual corruption (e.g.
the STOP_RING bit) from issuing the GPU reset that we need to fixup
before continuing.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_lrc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 37fe842de639..de0cde3a19f6 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1918,6 +1918,8 @@ static void execlists_reset(struct intel_engine_cs *engine,
 
 	spin_unlock_irqrestore(&engine->timeline.lock, flags);
 
+	/* Only adjust the actual context image clobbered by the reset */
+	request = i915_gem_find_active_request(engine);
 	if (!request)
 		return;
 
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-08-14 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 13:58 [PATCH 1/2] drm/i915/execlists: Clear STOP_RING bit before restoring the context Chris Wilson
2018-08-14 13:58 ` Chris Wilson [this message]
2018-08-14 14:12   ` [PATCH] drm/i915/execlists: Refind the active request before resetting Chris Wilson
2018-08-14 14:49   ` ✓ Fi.CI.BAT: success for " Patchwork
2018-08-14 19:41   ` ✓ Fi.CI.IGT: " Patchwork
2018-08-14 15:12 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/execlists: Clear STOP_RING bit before restoring the context Patchwork
2018-08-14 14:41 [PATCH 1/2] " Chris Wilson
2018-08-14 14:41 ` [PATCH 2/2] drm/i915/execlists: Refind the active request before resetting Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814135811.3300-2-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.