From: Oscar Salvador <osalvador@techadventures.net>
To: akpm@linux-foundation.org
Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com,
yasu.isimatu@gmail.com, jonathan.cameron@huawei.com,
david@redhat.com, Pavel.Tatashin@microsoft.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v4 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes
Date: Fri, 17 Aug 2018 11:00:17 +0200 [thread overview]
Message-ID: <20180817090017.17610-5-osalvador@techadventures.net> (raw)
In-Reply-To: <20180817090017.17610-1-osalvador@techadventures.net>
From: Oscar Salvador <osalvador@suse.de>
We are getting the nid from the pages that are not yet removed,
but a node can only be offline when its memory/cpu's have been removed.
Therefore, we know that the node is still online.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
---
drivers/base/node.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c
index 6b8c9b4537c9..01e9190be010 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -464,8 +464,6 @@ void unregister_mem_sect_under_nodes(struct memory_block *mem_blk,
if (nid < 0)
continue;
- if (!node_online(nid))
- continue;
if (node_test_and_set(nid, unlinked_nodes))
continue;
--
2.13.6
next prev parent reply other threads:[~2018-08-17 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 9:00 [PATCH v4 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes Oscar Salvador
2018-08-17 9:00 ` [PATCH v4 1/4] mm/memory-hotplug: Drop unused args from remove_memory_section Oscar Salvador
2018-08-17 9:00 ` [PATCH v4 2/4] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes Oscar Salvador
2018-08-17 9:00 ` [PATCH v4 3/4] mm/memory_hotplug: Define nodemask_t as a stack variable Oscar Salvador
2018-08-17 9:49 ` David Hildenbrand
2018-08-28 11:54 ` Oscar Salvador
2018-08-28 14:04 ` Pasha Tatashin
2018-08-17 9:00 ` Oscar Salvador [this message]
2018-08-21 16:21 ` [PATCH v4 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes Oscar Salvador
2018-08-21 20:43 ` Andrew Morton
2018-08-29 20:50 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817090017.17610-5-osalvador@techadventures.net \
--to=osalvador@techadventures.net \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.