From: guangrong.xiao@gmail.com
To: pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com
Cc: kvm@vger.kernel.org, Xiao Guangrong <xiaoguangrong@tencent.com>,
qemu-devel@nongnu.org, peterx@redhat.com, dgilbert@redhat.com,
wei.w.wang@intel.com, jiang.biao2@zte.com.cn
Subject: [PATCH v4 02/10] migration: fix counting normal page for compression
Date: Tue, 21 Aug 2018 16:10:21 +0800 [thread overview]
Message-ID: <20180821081029.26121-3-xiaoguangrong@tencent.com> (raw)
In-Reply-To: <20180821081029.26121-1-xiaoguangrong@tencent.com>
From: Xiao Guangrong <xiaoguangrong@tencent.com>
The compressed page is not normal page
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com>
---
migration/ram.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index ae9e83c2b6..d631b9a6fe 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1903,7 +1903,6 @@ retry:
qemu_cond_signal(&comp_param[idx].cond);
qemu_mutex_unlock(&comp_param[idx].mutex);
pages = 1;
- ram_counters.normal++;
ram_counters.transferred += bytes_xmit;
break;
}
--
2.14.4
WARNING: multiple messages have this Message-ID (diff)
From: guangrong.xiao@gmail.com
To: pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, dgilbert@redhat.com,
peterx@redhat.com, wei.w.wang@intel.com, jiang.biao2@zte.com.cn,
eblake@redhat.com, Xiao Guangrong <xiaoguangrong@tencent.com>
Subject: [Qemu-devel] [PATCH v4 02/10] migration: fix counting normal page for compression
Date: Tue, 21 Aug 2018 16:10:21 +0800 [thread overview]
Message-ID: <20180821081029.26121-3-xiaoguangrong@tencent.com> (raw)
In-Reply-To: <20180821081029.26121-1-xiaoguangrong@tencent.com>
From: Xiao Guangrong <xiaoguangrong@tencent.com>
The compressed page is not normal page
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com>
---
migration/ram.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index ae9e83c2b6..d631b9a6fe 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1903,7 +1903,6 @@ retry:
qemu_cond_signal(&comp_param[idx].cond);
qemu_mutex_unlock(&comp_param[idx].mutex);
pages = 1;
- ram_counters.normal++;
ram_counters.transferred += bytes_xmit;
break;
}
--
2.14.4
next prev parent reply other threads:[~2018-08-21 8:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 8:10 [PATCH v4 00/10] migration: compression optimization guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-21 8:10 ` [PATCH v4 01/10] migration: do not wait for free thread guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 10:25 ` Juan Quintela
2018-08-22 10:25 ` [Qemu-devel] " Juan Quintela
2018-08-21 8:10 ` guangrong.xiao [this message]
2018-08-21 8:10 ` [Qemu-devel] [PATCH v4 02/10] migration: fix counting normal page for compression guangrong.xiao
2018-08-22 10:20 ` Juan Quintela
2018-08-22 10:20 ` [Qemu-devel] " Juan Quintela
2018-08-21 8:10 ` [PATCH v4 03/10] migration: introduce save_zero_page_to_file guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 10:21 ` Juan Quintela
2018-08-22 10:21 ` [Qemu-devel] " Juan Quintela
2018-08-21 8:10 ` [PATCH v4 04/10] migration: drop the return value of do_compress_ram_page guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 10:22 ` Juan Quintela
2018-08-22 10:22 ` [Qemu-devel] " Juan Quintela
2018-08-21 8:10 ` [PATCH v4 05/10] migration: move handle of zero page to the thread guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 10:25 ` Juan Quintela
2018-08-22 10:25 ` [Qemu-devel] " Juan Quintela
2018-08-21 8:10 ` [PATCH v4 06/10] migration: hold the lock only if it is really needed guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 10:24 ` Juan Quintela
2018-08-22 10:24 ` [Qemu-devel] " Juan Quintela
2018-08-21 8:10 ` [PATCH v4 07/10] migration: do not flush_compressed_data at the end of each iteration guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 4:56 ` Peter Xu
2018-08-22 4:56 ` [Qemu-devel] " Peter Xu
2018-08-21 8:10 ` [PATCH v4 08/10] migration: fix calculating xbzrle_counters.cache_miss_rate guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-22 4:58 ` Peter Xu
2018-08-22 4:58 ` [Qemu-devel] " Peter Xu
2018-08-21 8:10 ` [PATCH v4 09/10] migration: show the statistics of compression guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
2018-08-21 8:10 ` [PATCH v4 10/10] migration: handle the error condition properly guangrong.xiao
2018-08-21 8:10 ` [Qemu-devel] " guangrong.xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821081029.26121-3-xiaoguangrong@tencent.com \
--to=guangrong.xiao@gmail.com \
--cc=dgilbert@redhat.com \
--cc=jiang.biao2@zte.com.cn \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.w.wang@intel.com \
--cc=xiaoguangrong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.