All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Li Yang <leoyang.li@nxp.com>
Cc: Roy Pledge <roy.pledge@nxp.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available
Date: Thu, 23 Aug 2018 23:35:59 +0200	[thread overview]
Message-ID: <20180823213600.23426-1-alexandre.belloni@bootlin.com> (raw)

If the qman driver (qman_ccsr) doesn't probe or fail to probe before
qman_portal, qm_ccsr_start will be either NULL or a stale pointer to an
unmapped page.

This leads to a crash when probing  qman_portal as the init_pcfg function
calls qman_liodn_fixup that tries to read qman registers.

Assume that qman didn't probe when the pool mask is 0.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/soc/fsl/qbman/qman_portal.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/soc/fsl/qbman/qman_portal.c b/drivers/soc/fsl/qbman/qman_portal.c
index a120002b630e..4fc80d2c8feb 100644
--- a/drivers/soc/fsl/qbman/qman_portal.c
+++ b/drivers/soc/fsl/qbman/qman_portal.c
@@ -277,6 +277,8 @@ static int qman_portal_probe(struct platform_device *pdev)
 	}
 
 	pcfg->pools = qm_get_pools_sdqcr();
+	if (pcfg->pools == 0)
+		return -EPROBE_DEFER;
 
 	spin_lock(&qman_lock);
 	cpu = cpumask_next_zero(-1, &portal_cpus);
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@bootlin.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available
Date: Thu, 23 Aug 2018 23:35:59 +0200	[thread overview]
Message-ID: <20180823213600.23426-1-alexandre.belloni@bootlin.com> (raw)

If the qman driver (qman_ccsr) doesn't probe or fail to probe before
qman_portal, qm_ccsr_start will be either NULL or a stale pointer to an
unmapped page.

This leads to a crash when probing  qman_portal as the init_pcfg function
calls qman_liodn_fixup that tries to read qman registers.

Assume that qman didn't probe when the pool mask is 0.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/soc/fsl/qbman/qman_portal.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/soc/fsl/qbman/qman_portal.c b/drivers/soc/fsl/qbman/qman_portal.c
index a120002b630e..4fc80d2c8feb 100644
--- a/drivers/soc/fsl/qbman/qman_portal.c
+++ b/drivers/soc/fsl/qbman/qman_portal.c
@@ -277,6 +277,8 @@ static int qman_portal_probe(struct platform_device *pdev)
 	}
 
 	pcfg->pools = qm_get_pools_sdqcr();
+	if (pcfg->pools == 0)
+		return -EPROBE_DEFER;
 
 	spin_lock(&qman_lock);
 	cpu = cpumask_next_zero(-1, &portal_cpus);
-- 
2.18.0

             reply	other threads:[~2018-08-23 21:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 21:35 Alexandre Belloni [this message]
2018-08-23 21:35 ` [PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available Alexandre Belloni
2018-08-23 21:36 ` [PATCH 2/2] soc: fsl: qbman: qman: avoid allocating from non existing gen_pool Alexandre Belloni
2018-08-23 21:36   ` Alexandre Belloni
2018-08-24 14:53   ` Roy Pledge
2018-08-24 14:53     ` Roy Pledge
2018-08-24 14:53     ` Roy Pledge
2018-08-24 14:52 ` [PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available Roy Pledge
2018-08-24 14:52   ` Roy Pledge
2018-08-24 14:52   ` Roy Pledge
2018-08-28 22:49   ` Li Yang
2018-08-28 22:49     ` Li Yang
2018-08-28 22:49     ` Li Yang
2018-09-25 19:45 ` Olof Johansson
2018-09-25 19:45   ` Olof Johansson
2018-09-25 22:11   ` Li Yang
2018-09-25 22:11     ` Li Yang
2018-09-25 22:11     ` Li Yang
2018-09-26  9:27   ` Alexandre Belloni
2018-09-26  9:27     ` Alexandre Belloni
2018-09-26 18:15     ` Li Yang
2018-09-26 18:15       ` Li Yang
2018-09-26 18:15       ` Li Yang
2018-09-27 19:24       ` Li Yang
2018-09-27 19:24         ` Li Yang
2018-09-27 19:24         ` Li Yang
2018-09-27 19:24         ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180823213600.23426-1-alexandre.belloni@bootlin.com \
    --to=alexandre.belloni@bootlin.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=roy.pledge@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.