All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Prakash Sangappa <prakash.sangappa@oracle.com>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: [PATCH v3 2/4] userfaultfd: selftest: Skip test if userfaultfd() syscall not supported
Date: Tue, 28 Aug 2018 14:26:06 -0300	[thread overview]
Message-ID: <20180828172608.30075-3-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20180828172608.30075-1-bauerman@linux.ibm.com>

Since there's no point in doing anything in this case, immediately exit the
process.

And take the opportunity to improve the error message.

Before:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 40
  userfaultfd syscall not available in this kernel
  # echo $?
  1

After:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 40
  userfaultfd syscall not available in this kernel: Function not implemented
  # echo $?
  4

Suggested-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Acked-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
---
 tools/testing/selftests/vm/userfaultfd.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index e4099afe7557..d728bd1cb33c 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -636,9 +636,11 @@ static int userfaultfd_open(int features)
 
 	uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);
 	if (uffd < 0) {
-		fprintf(stderr,
-			"userfaultfd syscall not available in this kernel\n");
-		return 1;
+		int errnum = errno;
+
+		perror("userfaultfd syscall not available in this kernel");
+
+		exit(errnum == ENOSYS ? KSFT_SKIP : 1);
 	}
 	uffd_flags = fcntl(uffd, F_GETFD, NULL);
 


WARNING: multiple messages have this Message-ID (diff)
From: bauerman at linux.ibm.com (Thiago Jung Bauermann)
Subject: [PATCH v3 2/4] userfaultfd: selftest: Skip test if userfaultfd() syscall not supported
Date: Tue, 28 Aug 2018 14:26:06 -0300	[thread overview]
Message-ID: <20180828172608.30075-3-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20180828172608.30075-1-bauerman@linux.ibm.com>

Since there's no point in doing anything in this case, immediately exit the
process.

And take the opportunity to improve the error message.

Before:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 40
  userfaultfd syscall not available in this kernel
  # echo $?
  1

After:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 40
  userfaultfd syscall not available in this kernel: Function not implemented
  # echo $?
  4

Suggested-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
Signed-off-by: Thiago Jung Bauermann <bauerman at linux.ibm.com>
Acked-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
---
 tools/testing/selftests/vm/userfaultfd.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index e4099afe7557..d728bd1cb33c 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -636,9 +636,11 @@ static int userfaultfd_open(int features)
 
 	uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);
 	if (uffd < 0) {
-		fprintf(stderr,
-			"userfaultfd syscall not available in this kernel\n");
-		return 1;
+		int errnum = errno;
+
+		perror("userfaultfd syscall not available in this kernel");
+
+		exit(errnum == ENOSYS ? KSFT_SKIP : 1);
 	}
 	uffd_flags = fcntl(uffd, F_GETFD, NULL);
 

WARNING: multiple messages have this Message-ID (diff)
From: bauerman@linux.ibm.com (Thiago Jung Bauermann)
Subject: [PATCH v3 2/4] userfaultfd: selftest: Skip test if userfaultfd() syscall not supported
Date: Tue, 28 Aug 2018 14:26:06 -0300	[thread overview]
Message-ID: <20180828172608.30075-3-bauerman@linux.ibm.com> (raw)
Message-ID: <20180828172606.JSylSNePhsj4mOTtENtv8V1LjyQSJgy0Z7aqCI7RUzU@z> (raw)
In-Reply-To: <20180828172608.30075-1-bauerman@linux.ibm.com>

Since there's no point in doing anything in this case, immediately exit the
process.

And take the opportunity to improve the error message.

Before:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 40
  userfaultfd syscall not available in this kernel
  # echo $?
  1

After:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 40
  userfaultfd syscall not available in this kernel: Function not implemented
  # echo $?
  4

Suggested-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
Signed-off-by: Thiago Jung Bauermann <bauerman at linux.ibm.com>
Acked-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
---
 tools/testing/selftests/vm/userfaultfd.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index e4099afe7557..d728bd1cb33c 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -636,9 +636,11 @@ static int userfaultfd_open(int features)
 
 	uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);
 	if (uffd < 0) {
-		fprintf(stderr,
-			"userfaultfd syscall not available in this kernel\n");
-		return 1;
+		int errnum = errno;
+
+		perror("userfaultfd syscall not available in this kernel");
+
+		exit(errnum == ENOSYS ? KSFT_SKIP : 1);
 	}
 	uffd_flags = fcntl(uffd, F_GETFD, NULL);
 

  parent reply	other threads:[~2018-08-28 17:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 17:26 [PATCH v3 0/4] userfaultfd: selftest: Improve behavior with older kernels Thiago Jung Bauermann
2018-08-28 17:26 ` Thiago Jung Bauermann
2018-08-28 17:26 ` bauerman
2018-08-28 17:26 ` [PATCH v3 1/4] userfaultfd: selftest: Fix checking of userfaultfd_open() result Thiago Jung Bauermann
2018-08-28 17:26   ` Thiago Jung Bauermann
2018-08-28 17:26   ` bauerman
2018-08-28 17:26 ` Thiago Jung Bauermann [this message]
2018-08-28 17:26   ` [PATCH v3 2/4] userfaultfd: selftest: Skip test if userfaultfd() syscall not supported Thiago Jung Bauermann
2018-08-28 17:26   ` bauerman
2018-08-28 17:26 ` [PATCH v3 3/4] userfaultfd: selftest: Skip test if a feature isn't supported Thiago Jung Bauermann
2018-08-28 17:26   ` Thiago Jung Bauermann
2018-08-28 17:26   ` bauerman
2018-08-28 17:26 ` [PATCH v3 4/4] userfaultfd: selftest: make supported range ioctl verification more robust Thiago Jung Bauermann
2018-08-28 17:26   ` Thiago Jung Bauermann
2018-08-28 17:26   ` bauerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828172608.30075-3-bauerman@linux.ibm.com \
    --to=bauerman@linux.ibm.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=prakash.sangappa@oracle.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.