All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 03/13] drm/i915: Use pipe A primary plane .max_stride() as the global stride limit
Date: Fri,  7 Sep 2018 18:24:03 +0300	[thread overview]
Message-ID: <20180907152413.15761-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20180907152413.15761-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Let's assume that the primary plane for pipe A has the highest max
stride of all planes, and we'll use that as the global limit when
creating a new framebuffer.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 33 ++++++++++-----------------------
 1 file changed, 10 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 323fdee6d88a..417d5d24cc8d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14432,31 +14432,18 @@ static
 u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
 			 uint64_t fb_modifier, uint32_t pixel_format)
 {
-	u32 gen = INTEL_GEN(dev_priv);
+	struct intel_crtc *crtc;
+	struct intel_plane *plane;
 
-	if (gen >= 9) {
-		int cpp = drm_format_plane_cpp(pixel_format, 0);
+	/*
+	 * We assume the primary plane for pipe A has
+	 * the highest stride limits of them all.
+	 */
+	crtc = intel_get_crtc_for_pipe(dev_priv, PIPE_A);
+	plane = to_intel_plane(crtc->base.primary);
 
-		/* "The stride in bytes must not exceed the of the size of 8K
-		 *  pixels and 32K bytes."
-		 */
-		return min(8192 * cpp, 32768);
-	} else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
-		return 32*1024;
-	} else if (gen >= 4) {
-		if (fb_modifier == I915_FORMAT_MOD_X_TILED)
-			return 16*1024;
-		else
-			return 32*1024;
-	} else if (gen >= 3) {
-		if (fb_modifier == I915_FORMAT_MOD_X_TILED)
-			return 8*1024;
-		else
-			return 16*1024;
-	} else {
-		/* XXX DSPC is limited to 4k tiled */
-		return 8*1024;
-	}
+	return plane->max_stride(plane, pixel_format, fb_modifier,
+				 DRM_MODE_ROTATE_0);
 }
 
 static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
-- 
2.16.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-09-07 15:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 15:24 [PATCH 00/13] drm/i915: Display gtt remapping prep stuff Ville Syrjala
2018-09-07 15:24 ` [PATCH 01/13] drm/i915: s/tile_offset/aligned_offset/ etc Ville Syrjala
2018-09-07 15:24 ` [PATCH 02/13] drm/i915: Add .max_stride() plane hook Ville Syrjala
2018-09-07 15:24 ` Ville Syrjala [this message]
2018-09-07 15:24 ` [PATCH 04/13] drm/i915: Rename the plane_state->main/aux to plane_state->color_plane[] Ville Syrjala
2018-09-07 15:30   ` Chris Wilson
2018-09-07 15:54     ` Ville Syrjälä
2018-09-07 15:24 ` [PATCH 05/13] drm/i915: Store the final plane stride in plane_state Ville Syrjala
2018-09-11 15:01   ` [PATCH v4 " Ville Syrjala
2018-09-07 15:24 ` [PATCH 06/13] drm/i915: Store ggtt_view " Ville Syrjala
2018-09-07 15:24 ` [PATCH 07/13] drm/i915: s/int plane/int color_plane/ Ville Syrjala
2018-09-07 15:24 ` [PATCH 08/13] drm/i915: Nuke plane->can_scale/min_downscale Ville Syrjala
2018-09-07 15:24 ` [PATCH 09/13] drm/i915: Extract per-platform plane->check() functions Ville Syrjala
2018-09-07 15:24 ` [PATCH 10/13] drm/i915: Move skl plane fb related checks into a better place Ville Syrjala
2018-09-07 15:24 ` [PATCH 11/13] drm/i915: Move display w/a #1175 Ville Syrjala
2018-09-07 15:24 ` [PATCH 12/13] drm/i915: Move chv rotation checks to plane->check() Ville Syrjala
2018-09-07 15:24 ` [PATCH 13/13] drm/i915: Extract intel_cursor_check_surface() Ville Syrjala
2018-09-07 16:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Display gtt remapping prep stuff Patchwork
2018-09-07 16:13 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-09-07 16:25 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-07 18:00 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-11 16:40 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Display gtt remapping prep stuff (rev2) Patchwork
2018-09-11 16:45 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-09-11 16:58 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-11 20:39 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-12 15:13 ` [PATCH 00/13] drm/i915: Display gtt remapping prep stuff Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907152413.15761-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.