All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	mst@redhat.com, jasowang@redhat.com
Subject: [PATCH net-next V2 00/11] vhost_net TX batching
Date: Wed, 12 Sep 2018 11:16:58 +0800	[thread overview]
Message-ID: <20180912031709.14112-1-jasowang@redhat.com> (raw)

Hi all:

This series tries to batch submitting packets to underlayer socket
through msg_control during sendmsg(). This is done by:

1) Doing userspace copy inside vhost_net
2) Build XDP buff
3) Batch at most 64 (VHOST_NET_BATCH) XDP buffs and submit them once
   through msg_control during sendmsg().
4) Underlayer sockets can use XDP buffs directly when XDP is enalbed,
   or build skb based on XDP buff.

For the packet that can not be built easily with XDP or for the case
that batch submission is hard (e.g sndbuf is limited). We will go for
the previous slow path, passing iov iterator to underlayer socket
through sendmsg() once per packet.

This can help to improve cache utilization and avoid lots of indirect
calls with sendmsg(). It can also co-operate with the batching support
of the underlayer sockets (e.g the case of XDP redirection through
maps).

Testpmd(txonly) in guest shows obvious improvements:

Test                /+pps%
XDP_DROP on TAP     /+44.8%
XDP_REDIRECT on TAP /+29%
macvtap (skb)       /+26%

Netperf TCP_STREAM TX from guest shows obvious improvements on small
packet:

    size/session/+thu%/+normalize%
       64/     1/   +2%/    0%
       64/     2/   +3%/   +1%
       64/     4/   +7%/   +5%
       64/     8/   +8%/   +6%
      256/     1/   +3%/    0%
      256/     2/  +10%/   +7%
      256/     4/  +26%/  +22%
      256/     8/  +27%/  +23%
      512/     1/   +3%/   +2%
      512/     2/  +19%/  +14%
      512/     4/  +43%/  +40%
      512/     8/  +45%/  +41%
     1024/     1/   +4%/    0%
     1024/     2/  +27%/  +21%
     1024/     4/  +38%/  +73%
     1024/     8/  +15%/  +24%
     2048/     1/  +10%/   +7%
     2048/     2/  +16%/  +12%
     2048/     4/    0%/   +2%
     2048/     8/    0%/   +2%
     4096/     1/  +36%/  +60%
     4096/     2/  -11%/  -26%
     4096/     4/    0%/  +14%
     4096/     8/    0%/   +4%
    16384/     1/   -1%/   +5%
    16384/     2/    0%/   +2%
    16384/     4/    0%/   -3%
    16384/     8/    0%/   +4%
    65535/     1/    0%/  +10%
    65535/     2/    0%/   +8%
    65535/     4/    0%/   +1%
    65535/     8/    0%/   +3%

Please review.

Thanks

Changes from V1:

- don't hold page refcnt for XDP_DROP
- release page if build_skb() fails
- introduce a helper to build skb for the path of no batching mode
- rename tun_do_xdp() as tun_xdp_act() and use negative for reporting
  errors instead of a pointer to integer
- introduce a num field in tun_msg_ctl
- introduce a new structure for storing metadata in the head of XDP
  packet
- do not store batche XDP inside vhoet_net_virtqueue

Jason Wang (11):
  net: sock: introduce SOCK_XDP
  tuntap: switch to use XDP_PACKET_HEADROOM
  tuntap: enable bh early during processing XDP
  tuntap: simplify error handling in tun_build_skb()
  tuntap: tweak on the path of skb XDP case in tun_build_skb()
  tuntap: split out XDP logic
  tuntap: move XDP flushing out of tun_do_xdp()
  tun: switch to new type of msg_control
  tuntap: accept an array of XDP buffs through sendmsg()
  tap: accept an array of XDP buffs through sendmsg()
  vhost_net: batch submitting XDP buffers to underlayer sockets

 drivers/net/tap.c      |  88 +++++++++++++-
 drivers/net/tun.c      | 267 ++++++++++++++++++++++++++++++++---------
 drivers/vhost/net.c    | 181 +++++++++++++++++++++++++---
 include/linux/if_tun.h |  14 +++
 include/net/sock.h     |   1 +
 5 files changed, 471 insertions(+), 80 deletions(-)

-- 
2.17.1


             reply	other threads:[~2018-09-12  3:17 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12  3:16 Jason Wang [this message]
2018-09-12  3:16 ` [PATCH net-next V2 01/11] net: sock: introduce SOCK_XDP Jason Wang
2018-09-12  3:16 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 02/11] tuntap: switch to use XDP_PACKET_HEADROOM Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 03/11] tuntap: enable bh early during processing XDP Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 04/11] tuntap: simplify error handling in tun_build_skb() Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 05/11] tuntap: tweak on the path of skb XDP case " Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 06/11] tuntap: split out XDP logic Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 07/11] tuntap: move XDP flushing out of tun_do_xdp() Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 08/11] tun: switch to new type of msg_control Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 09/11] tuntap: accept an array of XDP buffs through sendmsg() Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 10/11] tap: " Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-12  3:17 ` [PATCH net-next V2 11/11] vhost_net: batch submitting XDP buffers to underlayer sockets Jason Wang
2018-09-13 18:04   ` Michael S. Tsirkin
2018-09-13 18:04   ` Michael S. Tsirkin
2018-09-14  3:11     ` Jason Wang
2018-09-14  3:11     ` Jason Wang
2018-09-12  3:17 ` Jason Wang
2018-09-13 16:28 ` [PATCH net-next V2 00/11] vhost_net TX batching David Miller
2018-09-13 16:28 ` David Miller
2018-09-13 18:02   ` Michael S. Tsirkin
2018-09-13 18:05     ` David Miller
2018-09-13 18:05       ` David Miller
2018-09-13 18:02   ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2018-09-12  3:16 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180912031709.14112-1-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.