All of lore.kernel.org
 help / color / mirror / Atom feed
From: damenly.su@gmail.com
To: linux-btrfs@vger.kernel.org
Cc: suy.fnst@cn.fujitsu.com
Subject: [PATCH 3/6] btrfs-progs: lowmem check: find dir_item by di_key in check_dir_item()
Date: Wed, 12 Sep 2018 19:20:40 +0000	[thread overview]
Message-ID: <20180912192046.5861-4-suy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20180912192046.5861-1-suy.fnst@cn.fujitsu.com>

From: Su Yue <suy.fnst@cn.fujitsu.com>

In check_dir_item, we are going to search corresponding
dir_item/index.

Commit 564901eac7a4 ("btrfs-progs: check: introduce
print_dir_item_err()") Changed argument name from key to di_key but
forgot to change the key name for dir_item search.
So @key shouldn't be used here. It should be @di_key.

Fixes: 564901eac7a4 ("btrfs-progs: check: introduce print_dir_item_err()")
Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
 check/mode-lowmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check/mode-lowmem.c b/check/mode-lowmem.c
index 1bce44f5658a..89a304bbdd69 100644
--- a/check/mode-lowmem.c
+++ b/check/mode-lowmem.c
@@ -1658,7 +1658,7 @@ begin:
 
 		/* check relative INDEX/ITEM */
 		key.objectid = di_key->objectid;
-		if (key.type == BTRFS_DIR_ITEM_KEY) {
+		if (di_key->type == BTRFS_DIR_ITEM_KEY) {
 			key.type = BTRFS_DIR_INDEX_KEY;
 			key.offset = index;
 		} else {
-- 
2.18.0

  parent reply	other threads:[~2018-09-12 16:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 19:20 [PATCH 0/6] btrfs-progs: lowmem: bug fixes and inode_extref repair damenly.su
2018-09-12 12:35 ` Su Yue
2018-09-12 19:20 ` [PATCH 1/6] btrfs-progs: adjust arguments of btrfs_lookup_inode_extref() damenly.su
2018-09-12 19:20 ` [PATCH 2/6] btrfs-progs: make btrfs_unlink() lookup inode_extref damenly.su
2018-09-12 19:20 ` damenly.su [this message]
2018-09-12 19:20 ` [PATCH 4/6] btrfs-progs: lowmem: search key of root again after check_fs_root() under repair damenly.su
2018-09-12 19:20 ` [PATCH 5/6] btrfs-progs: lowmem: continue to check item in last slot while checking inodes damenly.su
2018-09-12 19:20 ` [PATCH 5/7] btrfs-progs: lowmem: improve check_inode_extref() damenly.su
2018-09-12 19:20 ` [PATCH 6/7] btrfs-progs: lowmem: continue to check item in last slot while checking inodes damenly.su
2018-09-12 19:20 ` [PATCH 6/6] btrfs-progs: lowmem: optimization and repair for check_inode_extref() damenly.su
2018-09-12 19:20 ` [PATCH 7/7] btrfs-progs: fsck-tests: add test case inode_extref without dir_item and dir_index damenly.su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180912192046.5861-4-suy.fnst@cn.fujitsu.com \
    --to=damenly.su@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=suy.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.