All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH v4 1/7] [media] ad5820: Define entity function
Date: Thu, 20 Sep 2018 22:47:45 +0200	[thread overview]
Message-ID: <20180920204751.29117-1-ricardo.ribalda@gmail.com> (raw)

Without this patch, media_device_register_entity throws a warning:

dev_warn(mdev->dev,
	 "Entity type for entity %s was not initialized!\n",
	 entity->name);

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/i2c/ad5820.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 907323f0ca3b..22759aaa2dba 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -317,6 +317,7 @@ static int ad5820_probe(struct i2c_client *client,
 	v4l2_i2c_subdev_init(&coil->subdev, client, &ad5820_ops);
 	coil->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 	coil->subdev.internal_ops = &ad5820_internal_ops;
+	coil->subdev.entity.function = MEDIA_ENT_F_LENS;
 	strscpy(coil->subdev.name, "ad5820 focus", sizeof(coil->subdev.name));
 
 	ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL);
-- 
2.18.0


             reply	other threads:[~2018-09-20 20:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 20:47 Ricardo Ribalda Delgado [this message]
2018-09-20 20:47 ` [PATCH v4 2/7] [media] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 3/7] [media] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2018-09-27 18:23   ` Rob Herring
2018-10-01  8:20     ` Ricardo Ribalda Delgado
2018-10-01 12:36       ` Rob Herring
2018-10-01 12:40         ` Ricardo Ribalda Delgado
2018-10-01 15:01           ` Rob Herring
2018-10-01 15:55             ` Laurent Pinchart
2018-10-02  7:18               ` Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 4/7] [media] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2018-09-27 19:29   ` Sakari Ailus
2018-09-20 20:47 ` [PATCH v4 5/7] [media] ad5820: Add support for acpi autoload Ricardo Ribalda Delgado
2018-09-27 19:32   ` Sakari Ailus
2018-09-20 20:47 ` [PATCH v4 6/7] [media] ad5820: Add support for ad5821 and ad5823 Ricardo Ribalda Delgado
2018-09-27 19:35   ` Sakari Ailus
2018-10-01  8:19     ` Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 7/7] [media] ad5820: DT new compatible devices Ricardo Ribalda Delgado
2018-09-27 18:23   ` Rob Herring
2018-09-27 18:23     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920204751.29117-1-ricardo.ribalda@gmail.com \
    --to=ricardo.ribalda@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.