All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Jacob Keller <jacob.keller@gmail.com>
Subject: [PATCH v3] coccicheck: process every source file at once
Date: Tue,  2 Oct 2018 13:07:10 -0700	[thread overview]
Message-ID: <20181002200710.15721-1-jacob.e.keller@intel.com> (raw)

From: Jacob Keller <jacob.keller@gmail.com>

make coccicheck is used in order to apply coccinelle semantic patches,
and see if any of the transformations found within contrib/coccinelle/
can be applied to the current code base.

Pass every file to a single invocation of spatch, instead of running
spatch once per source file.

This reduces the time required to run make coccicheck by a significant
amount of time:

Prior timing of make coccicheck
  real    6m14.090s
  user    25m2.606s
  sys     1m22.919s

New timing of make coccicheck
  real    1m36.580s
  user    7m55.933s
  sys     0m18.219s

This is nearly a 4x decrease in the time required to run make
coccicheck. This is due to the overhead of restarting spatch for every
file. By processing all files at once, we can amortize this startup cost
across the total number of files, rather than paying it once per file.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
---
 Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index df1df9db78da..da692ece9e12 100644
--- a/Makefile
+++ b/Makefile
@@ -2715,10 +2715,8 @@ endif
 %.cocci.patch: %.cocci $(COCCI_SOURCES)
 	@echo '    ' SPATCH $<; \
 	ret=0; \
-	for f in $(COCCI_SOURCES); do \
-		$(SPATCH) --sp-file $< $$f $(SPATCH_FLAGS) || \
-			{ ret=$$?; break; }; \
-	done >$@+ 2>$@.log; \
+	$(SPATCH) --sp-file $< $(COCCI_SOURCES) $(SPATCH_FLAGS) >$@+ 2>$@.log; \
+	ret=$$?; \
 	if test $$ret != 0; \
 	then \
 		cat $@.log; \
-- 
2.18.0.219.gaf81d287a9da


             reply	other threads:[~2018-10-02 20:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 20:07 Jacob Keller [this message]
2018-10-02 20:18 ` [PATCH v3] coccicheck: process every source file at once Jacob Keller
2018-10-05  2:17   ` Jacob Keller
2018-10-05 12:40     ` SZEDER Gábor
2018-10-05 16:25       ` Jeff King
2018-10-05 16:53         ` Keller, Jacob E
2018-10-05 16:59           ` Jeff King
2018-10-05 18:50             ` SZEDER Gábor
2018-10-05 19:00               ` Jeff King
2018-10-05 23:10                 ` Jacob Keller
2018-10-06  8:42                 ` René Scharfe
2018-10-09  3:11                   ` Jeff King
2018-10-05 18:39         ` SZEDER Gábor
2018-10-05 19:02           ` Jeff King
2018-10-05 19:54             ` SZEDER Gábor
2018-10-09  3:15               ` Jeff King
2018-10-10 11:44                 ` SZEDER Gábor
2018-10-10 13:59                   ` Jeff King
2018-10-07 11:36   ` Beat Bolli
2018-10-07 11:49     ` Beat Bolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002200710.15721-1-jacob.e.keller@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.