[ndctl PATCH v2 4/5] util/json: Add comments around re-checking the UTIL_JSON_MEDIA_ERRORS flag

[Vishal Verma <vishal.l.verma@intel.com>]

Add comments to clarify that in the various ndctl_*_babdlock_foreach
loops where we compose the json output, the additional check for
UTIL_JSON_MEDIA_ERRORS is valid because even if we're not printing
media errors, we still want the badblock_count to be updated, which
requires a full badblocks traversal.

Cc: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 util/json.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/util/json.c b/util/json.c
index 30b56c3..702ccf4 100644
--- a/util/json.c
+++ b/util/json.c
@@ -465,6 +465,7 @@ struct json_object *util_region_badblocks_to_json(struct ndctl_region *region,
 
 		bbs += bb->len;
 
+		/* recheck so we can still get the badblocks_count from above */
 		if (!(flags & UTIL_JSON_MEDIA_ERRORS))
 			continue;
 
@@ -554,6 +555,7 @@ static struct json_object *dev_badblocks_to_json(struct ndctl_region *region,
 
 		bbs += len;
 
+		/* recheck so we can still get the badblocks_count from above */
 		if (!(flags & UTIL_JSON_MEDIA_ERRORS))
 			continue;
 
-- 
2.17.1

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm