All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: [RFC PATCH 1/3] target: remove unused session digest-errors metric
Date: Wed, 17 Oct 2018 15:48:18 +0000	[thread overview]
Message-ID: <20181017154820.9722-2-ddiss@suse.de> (raw)

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 drivers/target/iscsi/iscsi_target_stat.c | 14 +-------------
 include/target/iscsi/iscsi_target_stat.h |  2 --
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target_stat.c b/drivers/target/iscsi/iscsi_target_stat.c
index df0a39811dc2..ce60d123aa90 100644
--- a/drivers/target/iscsi/iscsi_target_stat.c
+++ b/drivers/target/iscsi/iscsi_target_stat.c
@@ -103,8 +103,7 @@ static ssize_t iscsi_stat_instance_fail_sess_show(struct config_item *item,
 	u32 sess_err_count;
 
 	spin_lock_bh(&sess_err->lock);
-	sess_err_count = (sess_err->digest_errors +
-			  sess_err->cxn_timeout_errors +
+	sess_err_count = (sess_err->cxn_timeout_errors +
 			  sess_err->pdu_format_errors);
 	spin_unlock_bh(&sess_err->lock);
 
@@ -209,15 +208,6 @@ static ssize_t iscsi_stat_sess_err_inst_show(struct config_item *item,
 		iscsi_sess_err_tiqn(item)->tiqn_index);
 }
 
-static ssize_t iscsi_stat_sess_err_digest_errors_show(struct config_item *item,
-		char *page)
-{
-	struct iscsi_tiqn *tiqn = iscsi_sess_err_tiqn(item);
-	struct iscsi_sess_err_stats *sess_err = &tiqn->sess_err_stats;
-
-	return snprintf(page, PAGE_SIZE, "%u\n", sess_err->digest_errors);
-}
-
 static ssize_t iscsi_stat_sess_err_cxn_errors_show(struct config_item *item,
 		char *page)
 {
@@ -237,13 +227,11 @@ static ssize_t iscsi_stat_sess_err_format_errors_show(struct config_item *item,
 }
 
 CONFIGFS_ATTR_RO(iscsi_stat_sess_err_, inst);
-CONFIGFS_ATTR_RO(iscsi_stat_sess_err_, digest_errors);
 CONFIGFS_ATTR_RO(iscsi_stat_sess_err_, cxn_errors);
 CONFIGFS_ATTR_RO(iscsi_stat_sess_err_, format_errors);
 
 static struct configfs_attribute *iscsi_stat_sess_err_attrs[] = {
 	&iscsi_stat_sess_err_attr_inst,
-	&iscsi_stat_sess_err_attr_digest_errors,
 	&iscsi_stat_sess_err_attr_cxn_errors,
 	&iscsi_stat_sess_err_attr_format_errors,
 	NULL,
diff --git a/include/target/iscsi/iscsi_target_stat.h b/include/target/iscsi/iscsi_target_stat.h
index 4d75a2c426ca..b2d0f190483d 100644
--- a/include/target/iscsi/iscsi_target_stat.h
+++ b/include/target/iscsi/iscsi_target_stat.h
@@ -22,14 +22,12 @@ extern const struct config_item_type iscsi_stat_sess_cit;
 
 /* iSCSI session error types */
 #define ISCSI_SESS_ERR_UNKNOWN		0
-#define ISCSI_SESS_ERR_DIGEST		1
 #define ISCSI_SESS_ERR_CXN_TIMEOUT	2
 #define ISCSI_SESS_ERR_PDU_FORMAT	3
 
 /* iSCSI session error stats */
 struct iscsi_sess_err_stats {
 	spinlock_t	lock;
-	u32		digest_errors;
 	u32		cxn_timeout_errors;
 	u32		pdu_format_errors;
 	u32		last_sess_failure_type;
-- 
2.13.7

                 reply	other threads:[~2018-10-17 15:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017154820.9722-2-ddiss@suse.de \
    --to=ddiss@suse.de \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.