All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 37/40] vl: Simplify call of parse_name()
Date: Mon, 22 Oct 2018 14:34:10 +0200	[thread overview]
Message-ID: <20181022123413.28044-38-armbru@redhat.com> (raw)
In-Reply-To: <20181022123413.28044-1-armbru@redhat.com>

main() checks for parse_name() failure even though it can't actually
fail.  That's okay.  Simplify it to check by passing &error_fatal,
like the other users of qemu_opts_foreach().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20181017082702.5581-36-armbru@redhat.com>
---
 vl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/vl.c b/vl.c
index 812ceba425..d53e2563e9 100644
--- a/vl.c
+++ b/vl.c
@@ -3974,10 +3974,8 @@ int main(int argc, char **argv, char **envp)
     }
 #endif
 
-    if (qemu_opts_foreach(qemu_find_opts("name"),
-                          parse_name, NULL, NULL)) {
-        exit(1);
-    }
+    qemu_opts_foreach(qemu_find_opts("name"),
+                      parse_name, NULL, &error_fatal);
 
 #ifndef _WIN32
     qemu_opts_foreach(qemu_find_opts("add-fd"),
-- 
2.17.2

  parent reply	other threads:[~2018-10-22 12:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22 12:33 [Qemu-devel] [PULL 00/40] Error reporting patches for 2018-10-22 Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 01/40] scripts: Remove check-qerror.sh Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 02/40] vl: Print error when using incorrect backend for debugcon Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 03/40] error: Fix use of error_prepend() with &error_fatal, &error_abort Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 04/40] Use error_fatal to simplify obvious fatal errors (again) Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 05/40] block: Use warn_report() & friends to report warnings Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 06/40] cpus hw target: " Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 07/40] vfio: " Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 08/40] vfio: Clean up error reporting after previous commit Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 09/40] char: Use error_printf() to print help and such Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 10/40] 9pfs: Fix CLI parsing crash on error Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 11/40] pc: Fix machine property nvdimm-persistence error handling Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 12/40] ioapic: Fix error handling in realize() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 13/40] smbios: Clean up error handling in smbios_add() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 14/40] migration: Fix !replay_can_snapshot() error handling Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 15/40] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 16/40] net/socket: Fix invalid socket type error handling Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 17/40] numa: Fix QMP command set-numa-node " Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 18/40] xen/pt: Fix incomplete conversion to realize() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 19/40] seccomp: Clean up error reporting in parse_sandbox() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 20/40] vl: Clean up error reporting in parse_add_fd() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 21/40] qom: Clean up error reporting in user_creatable_add_opts_foreach() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 22/40] vl: Clean up error reporting in chardev_init_func() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 23/40] vl: Clean up error reporting in machine_set_property() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 24/40] vl: Clean up error reporting in mon_init_func() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 25/40] vl: Clean up error reporting in parse_fw_cfg() Markus Armbruster
2018-10-22 12:33 ` [Qemu-devel] [PULL 26/40] vl: Clean up error reporting in device_init_func() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 27/40] ui/keymaps: Fix handling of erroneous include files Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 28/40] ui: Convert vnc_display_init(), init_keyboard_layout() to Error Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 29/40] vnc: Clean up error reporting in vnc_init_func() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 30/40] numa: Clean up error reporting in parse_numa() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 31/40] tpm: Clean up error reporting in tpm_init_tpmdev() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 32/40] spice: Clean up error reporting in add_channel() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 33/40] fsdev: Clean up error reporting in qemu_fsdev_add() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 34/40] vl: Assert drive_new() does not fail in default_drive() Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 35/40] blockdev: Convert drive_new() to Error Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 36/40] vl: Fix exit status for -drive format=help Markus Armbruster
2018-10-22 12:34 ` Markus Armbruster [this message]
2018-10-22 12:34 ` [Qemu-devel] [PULL 38/40] block: Clean up bdrv_img_create()'s error reporting Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 39/40] vpc: Fail open on bad header checksum Markus Armbruster
2018-10-22 12:34 ` [Qemu-devel] [PULL 40/40] error: Drop bogus "use error_setg() instead" admonitions Markus Armbruster
2018-10-23 18:58 ` [Qemu-devel] [PULL 00/40] Error reporting patches for 2018-10-22 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181022123413.28044-38-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.