All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
	Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	kernel@pengutronix.de
Subject: [PATCH 1/4] pwm: Add new helper to initialize a pwm_state variable with defaults
Date: Fri, 26 Oct 2018 20:41:55 +0200	[thread overview]
Message-ID: <20181026184157.16371-1-u.kleine-koenig@pengutronix.de> (raw)

This helps to convert drivers from the legacy API to pwm_apply_state without
having to make the aware of the configured polarity (and in some cases even
period).

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 include/linux/pwm.h | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index d5199b507d79..017d1e13e29d 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -522,6 +522,15 @@ static inline void devm_pwm_put(struct device *dev, struct pwm_device *pwm)
 }
 #endif
 
+static inline void pwm_get_state_default(const struct pwm_device *pwm,
+					 struct pwm_state *state)
+{
+	state->period = pwm->args.period;
+	state->duty_cycle = 0;
+	state->polarity = pwm->args.polarity;
+	state->enabled = false;
+}
+
 static inline void pwm_apply_args(struct pwm_device *pwm)
 {
 	struct pwm_state state = { };
@@ -547,9 +556,7 @@ static inline void pwm_apply_args(struct pwm_device *pwm)
 	 * pwm_apply_args().
 	 */
 
-	state.enabled = false;
-	state.polarity = pwm->args.polarity;
-	state.period = pwm->args.period;
+	pwm_get_state_default(pwm, &state);
 
 	pwm_apply_state(pwm, &state);
 }
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] pwm: Add new helper to initialize a pwm_state variable with defaults
Date: Fri, 26 Oct 2018 20:41:55 +0200	[thread overview]
Message-ID: <20181026184157.16371-1-u.kleine-koenig@pengutronix.de> (raw)

This helps to convert drivers from the legacy API to pwm_apply_state without
having to make the aware of the configured polarity (and in some cases even
period).

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 include/linux/pwm.h | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index d5199b507d79..017d1e13e29d 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -522,6 +522,15 @@ static inline void devm_pwm_put(struct device *dev, struct pwm_device *pwm)
 }
 #endif
 
+static inline void pwm_get_state_default(const struct pwm_device *pwm,
+					 struct pwm_state *state)
+{
+	state->period = pwm->args.period;
+	state->duty_cycle = 0;
+	state->polarity = pwm->args.polarity;
+	state->enabled = false;
+}
+
 static inline void pwm_apply_args(struct pwm_device *pwm)
 {
 	struct pwm_state state = { };
@@ -547,9 +556,7 @@ static inline void pwm_apply_args(struct pwm_device *pwm)
 	 * pwm_apply_args().
 	 */
 
-	state.enabled = false;
-	state.polarity = pwm->args.polarity;
-	state.period = pwm->args.period;
+	pwm_get_state_default(pwm, &state);
 
 	pwm_apply_state(pwm, &state);
 }
-- 
2.19.1

             reply	other threads:[~2018-10-26 18:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 18:41 Uwe Kleine-König [this message]
2018-10-26 18:41 ` [PATCH 1/4] pwm: Add new helper to initialize a pwm_state variable with defaults Uwe Kleine-König
2018-10-26 18:41 ` [PATCH 2/4] ARM: S3C24XX: rx1950: make use of atomic PWM API Uwe Kleine-König
2018-10-26 18:41   ` Uwe Kleine-König
2018-10-29 10:46   ` Krzysztof Kozlowski
2018-10-29 10:46     ` Krzysztof Kozlowski
2018-11-14  9:15     ` Uwe Kleine-König
2018-11-14  9:15       ` Uwe Kleine-König
2018-11-14 12:08   ` Thierry Reding
2018-11-14 12:08     ` Thierry Reding
2018-11-15  8:58     ` Uwe Kleine-König
2018-11-15  8:58       ` Uwe Kleine-König
2018-11-15 16:15       ` Thierry Reding
2018-11-15 16:15         ` Thierry Reding
2018-11-15 21:00         ` Uwe Kleine-König
2018-11-15 21:00           ` Uwe Kleine-König
2018-10-26 18:41 ` [PATCH 3/4] bus: ts-nbus: convert to " Uwe Kleine-König
2018-10-26 18:41   ` Uwe Kleine-König
2018-11-14 12:15   ` Thierry Reding
2018-11-14 12:15     ` Thierry Reding
2018-10-26 18:41 ` [PATCH 4/4] bus: ts-nbus: weaken driver dependency to allow broader compile testing Uwe Kleine-König
2018-10-26 18:41   ` Uwe Kleine-König
2018-11-14 12:18   ` Thierry Reding
2018-11-14 12:18     ` Thierry Reding
2018-10-29 11:33 ` [PATCH 1/4] pwm: Add new helper to initialize a pwm_state variable with defaults Thierry Reding
2018-10-29 11:33   ` Thierry Reding
2018-11-03 14:25   ` Uwe Kleine-König
2018-11-03 14:25     ` Uwe Kleine-König
2018-11-08 15:13     ` Uwe Kleine-König
2018-11-08 15:13       ` Uwe Kleine-König
2018-11-14 12:32 ` Thierry Reding
2018-11-14 12:32   ` Thierry Reding
2018-11-15  9:16   ` Uwe Kleine-König
2018-11-15  9:16     ` Uwe Kleine-König
2018-11-15 16:21     ` Thierry Reding
2018-11-15 16:21       ` Thierry Reding
2018-11-15 21:05       ` Uwe Kleine-König
2018-11-15 21:05         ` Uwe Kleine-König
2018-11-16 10:24         ` Thierry Reding
2018-11-16 10:24           ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026184157.16371-1-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=sebastien.bourdelin@savoirfairelinux.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.