All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH 2/5] drm/i915/cnl: Remove useless CNL A-stepping workarounds.
Date: Mon, 29 Oct 2018 16:00:41 -0700	[thread overview]
Message-ID: <20181029230044.12876-2-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20181029230044.12876-1-rodrigo.vivi@intel.com>

These were always useless since CNL A stepping needed many
more workarounds that were never introduced and also
we started Linux work on CNL B stepping anyways.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c    | 10 ++--------
 drivers/gpu/drm/i915/intel_wopcm.c |  3 +--
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 82c82e233154..9ee96016cfd5 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4824,12 +4824,11 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,
 	}
 
 	/*
-	 * Display WA #826 (SKL:ALL, BXT:ALL) & #1059 (CNL:A)
+	 * Display WA #826 (SKL:ALL, BXT:ALL)
 	 * disable wm level 1-7 on NV12 planes
 	 */
 	if (wp->is_planar && level >= 1 &&
-	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) ||
-	     IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_A0))) {
+	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
 		result->plane_en = false;
 		return 0;
 	}
@@ -4953,11 +4952,6 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
 				trans_offset_b;
 	} else {
 		res_blocks = wm0_sel_res_b + trans_offset_b;
-
-		/* WA BUG:1938466 add one block for non y-tile planes */
-		if (IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_A0))
-			res_blocks += 1;
-
 	}
 
 	res_blocks += 1;
diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/intel_wopcm.c
index 92cb82dd0c07..b8ee8669c260 100644
--- a/drivers/gpu/drm/i915/intel_wopcm.c
+++ b/drivers/gpu/drm/i915/intel_wopcm.c
@@ -133,8 +133,7 @@ static inline int check_hw_restriction(struct drm_i915_private *i915,
 	if (IS_GEN9(i915))
 		err = gen9_check_dword_gap(guc_wopcm_base, guc_wopcm_size);
 
-	if (!err &&
-	    (IS_GEN9(i915) || IS_CNL_REVID(i915, CNL_REVID_A0, CNL_REVID_A0)))
+	if (!err && IS_GEN9(i915))
 		err = gen9_check_huc_fw_fits(guc_wopcm_size, huc_fw_size);
 
 	return err;
-- 
2.19.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-10-29 23:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 23:00 [PATCH 1/5] drm/i915: Remove CNL from WA 827 Rodrigo Vivi
2018-10-29 23:00 ` Rodrigo Vivi [this message]
2018-10-29 23:57   ` [PATCH] drm/i915/cnl: Remove useless CNL A-stepping workarounds Rodrigo Vivi
2018-10-29 23:00 ` [PATCH 3/5] drm/i915: Introduce HAS_NV12 and define WA 0870 Rodrigo Vivi
2018-10-30 18:16   ` Ville Syrjälä
2018-10-30 22:15     ` [PATCH] drm/i915: Define WA 0870 and kill dead code Rodrigo Vivi
2018-10-31 13:07       ` Ville Syrjälä
2018-10-29 23:00 ` [PATCH 4/5] drm/i915: Kill WA 0528 Rodrigo Vivi
2018-10-30 18:32   ` Ville Syrjälä
2018-10-29 23:00 ` [PATCH 5/5] drm/i915: Kill WA 0826 Rodrigo Vivi
2018-10-30  0:00   ` [PATCH] " Rodrigo Vivi
2018-10-30 18:38   ` [PATCH 5/5] " Ville Syrjälä
2018-10-29 23:36 ` [PATCH 1/5] drm/i915: Remove CNL from WA 827 Clint Taylor
2018-10-29 23:58 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/5] " Patchwork
2018-10-30  0:16 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-30  1:00 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: Remove CNL from WA 827 (rev3) Patchwork
2018-10-30  1:17 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-30  8:35 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-30 22:54 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Remove CNL from WA 827 (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029230044.12876-2-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.