From: Jerome Brunet <jbrunet@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>, Carlo Caione <carlo@caione.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH] arm64: dts: meson-axg: fix dtc warning about unit address
Date: Tue, 30 Oct 2018 16:06:14 +0100 [thread overview]
Message-ID: <20181030150614.19461-1-jbrunet@baylibre.com> (raw)
section 2.2.1 of the DT specs says: " If the node has no reg property,
the @unit-address must be omitted and the node-name alone differentiates
the node from other nodes at the same level in the tree"
Simply replace the '@' with a '-' to fix this warning.
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
.../arm64/boot/dts/amlogic/meson-axg-s400.dts | 30 +++++++++----------
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++--
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index c74ff1efebb8..be6df3cc1b98 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -60,7 +60,7 @@
serial1 = &uart_A;
};
- linein: audio-codec@0 {
+ linein: audio-codec-0 {
#sound-dai-cells = <0>;
compatible = "everest,es7241";
VDDA-supply = <&vcc_3v3>;
@@ -70,7 +70,7 @@
sound-name-prefix = "Linein";
};
- lineout: audio-codec@1 {
+ lineout: audio-codec-1 {
#sound-dai-cells = <0>;
compatible = "everest,es7154";
VDD-supply = <&vcc_3v3>;
@@ -79,14 +79,14 @@
sound-name-prefix = "Lineout";
};
- spdif_dit: audio-codec@2 {
+ spdif_dit: audio-codec-2 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dit";
status = "okay";
sound-name-prefix = "DIT";
};
- dmics: audio-codec@3 {
+ dmics: audio-codec-3 {
#sound-dai-cells = <0>;
compatible = "dmic-codec";
num-channels = <7>;
@@ -95,7 +95,7 @@
sound-name-prefix = "MIC";
};
- spdif_dir: audio-codec@4 {
+ spdif_dir: audio-codec-4 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dir";
status = "okay";
@@ -282,31 +282,31 @@
<393216000>;
status = "okay";
- dai-link@0 {
+ dai-link-0 {
sound-dai = <&frddr_a>;
};
- dai-link@1 {
+ dai-link-1 {
sound-dai = <&frddr_b>;
};
- dai-link@2 {
+ dai-link-2 {
sound-dai = <&frddr_c>;
};
- dai-link@3 {
+ dai-link-3 {
sound-dai = <&toddr_a>;
};
- dai-link@4 {
+ dai-link-4 {
sound-dai = <&toddr_b>;
};
- dai-link@5 {
+ dai-link-5 {
sound-dai = <&toddr_c>;
};
- dai-link@6 {
+ dai-link-6 {
sound-dai = <&tdmif_c>;
dai-format = "i2s";
dai-tdm-slot-tx-mask-2 = <1 1>;
@@ -327,7 +327,7 @@
};
- dai-link@7 {
+ dai-link-7 {
sound-dai = <&spdifout>;
codec {
@@ -335,7 +335,7 @@
};
};
- dai-link@8 {
+ dai-link-8 {
sound-dai = <&spdifin>;
codec {
@@ -343,7 +343,7 @@
};
};
- dai-link@9 {
+ dai-link-9 {
sound-dai = <&pdm>;
codec {
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 8746433c71be..7ab1a627951f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -23,7 +23,7 @@
#address-cells = <2>;
#size-cells = <2>;
- tdmif_a: audio-controller@0 {
+ tdmif_a: audio-controller-0 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_A";
@@ -34,7 +34,7 @@
status = "disabled";
};
- tdmif_b: audio-controller@1 {
+ tdmif_b: audio-controller-1 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_B";
@@ -45,7 +45,7 @@
status = "disabled";
};
- tdmif_c: audio-controller@2 {
+ tdmif_c: audio-controller-2 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_C";
--
2.17.2
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: meson-axg: fix dtc warning about unit address
Date: Tue, 30 Oct 2018 16:06:14 +0100 [thread overview]
Message-ID: <20181030150614.19461-1-jbrunet@baylibre.com> (raw)
section 2.2.1 of the DT specs says: " If the node has no reg property,
the @unit-address must be omitted and the node-name alone differentiates
the node from other nodes at the same level in the tree"
Simply replace the '@' with a '-' to fix this warning.
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
.../arm64/boot/dts/amlogic/meson-axg-s400.dts | 30 +++++++++----------
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++--
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index c74ff1efebb8..be6df3cc1b98 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -60,7 +60,7 @@
serial1 = &uart_A;
};
- linein: audio-codec at 0 {
+ linein: audio-codec-0 {
#sound-dai-cells = <0>;
compatible = "everest,es7241";
VDDA-supply = <&vcc_3v3>;
@@ -70,7 +70,7 @@
sound-name-prefix = "Linein";
};
- lineout: audio-codec at 1 {
+ lineout: audio-codec-1 {
#sound-dai-cells = <0>;
compatible = "everest,es7154";
VDD-supply = <&vcc_3v3>;
@@ -79,14 +79,14 @@
sound-name-prefix = "Lineout";
};
- spdif_dit: audio-codec at 2 {
+ spdif_dit: audio-codec-2 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dit";
status = "okay";
sound-name-prefix = "DIT";
};
- dmics: audio-codec at 3 {
+ dmics: audio-codec-3 {
#sound-dai-cells = <0>;
compatible = "dmic-codec";
num-channels = <7>;
@@ -95,7 +95,7 @@
sound-name-prefix = "MIC";
};
- spdif_dir: audio-codec at 4 {
+ spdif_dir: audio-codec-4 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dir";
status = "okay";
@@ -282,31 +282,31 @@
<393216000>;
status = "okay";
- dai-link at 0 {
+ dai-link-0 {
sound-dai = <&frddr_a>;
};
- dai-link at 1 {
+ dai-link-1 {
sound-dai = <&frddr_b>;
};
- dai-link at 2 {
+ dai-link-2 {
sound-dai = <&frddr_c>;
};
- dai-link at 3 {
+ dai-link-3 {
sound-dai = <&toddr_a>;
};
- dai-link at 4 {
+ dai-link-4 {
sound-dai = <&toddr_b>;
};
- dai-link at 5 {
+ dai-link-5 {
sound-dai = <&toddr_c>;
};
- dai-link at 6 {
+ dai-link-6 {
sound-dai = <&tdmif_c>;
dai-format = "i2s";
dai-tdm-slot-tx-mask-2 = <1 1>;
@@ -327,7 +327,7 @@
};
- dai-link at 7 {
+ dai-link-7 {
sound-dai = <&spdifout>;
codec {
@@ -335,7 +335,7 @@
};
};
- dai-link at 8 {
+ dai-link-8 {
sound-dai = <&spdifin>;
codec {
@@ -343,7 +343,7 @@
};
};
- dai-link at 9 {
+ dai-link-9 {
sound-dai = <&pdm>;
codec {
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 8746433c71be..7ab1a627951f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -23,7 +23,7 @@
#address-cells = <2>;
#size-cells = <2>;
- tdmif_a: audio-controller at 0 {
+ tdmif_a: audio-controller-0 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_A";
@@ -34,7 +34,7 @@
status = "disabled";
};
- tdmif_b: audio-controller at 1 {
+ tdmif_b: audio-controller-1 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_B";
@@ -45,7 +45,7 @@
status = "disabled";
};
- tdmif_c: audio-controller at 2 {
+ tdmif_c: audio-controller-2 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_C";
--
2.17.2
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] arm64: dts: meson-axg: fix dtc warning about unit address
Date: Tue, 30 Oct 2018 16:06:14 +0100 [thread overview]
Message-ID: <20181030150614.19461-1-jbrunet@baylibre.com> (raw)
section 2.2.1 of the DT specs says: " If the node has no reg property,
the @unit-address must be omitted and the node-name alone differentiates
the node from other nodes at the same level in the tree"
Simply replace the '@' with a '-' to fix this warning.
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
.../arm64/boot/dts/amlogic/meson-axg-s400.dts | 30 +++++++++----------
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++--
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index c74ff1efebb8..be6df3cc1b98 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -60,7 +60,7 @@
serial1 = &uart_A;
};
- linein: audio-codec at 0 {
+ linein: audio-codec-0 {
#sound-dai-cells = <0>;
compatible = "everest,es7241";
VDDA-supply = <&vcc_3v3>;
@@ -70,7 +70,7 @@
sound-name-prefix = "Linein";
};
- lineout: audio-codec at 1 {
+ lineout: audio-codec-1 {
#sound-dai-cells = <0>;
compatible = "everest,es7154";
VDD-supply = <&vcc_3v3>;
@@ -79,14 +79,14 @@
sound-name-prefix = "Lineout";
};
- spdif_dit: audio-codec at 2 {
+ spdif_dit: audio-codec-2 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dit";
status = "okay";
sound-name-prefix = "DIT";
};
- dmics: audio-codec at 3 {
+ dmics: audio-codec-3 {
#sound-dai-cells = <0>;
compatible = "dmic-codec";
num-channels = <7>;
@@ -95,7 +95,7 @@
sound-name-prefix = "MIC";
};
- spdif_dir: audio-codec at 4 {
+ spdif_dir: audio-codec-4 {
#sound-dai-cells = <0>;
compatible = "linux,spdif-dir";
status = "okay";
@@ -282,31 +282,31 @@
<393216000>;
status = "okay";
- dai-link at 0 {
+ dai-link-0 {
sound-dai = <&frddr_a>;
};
- dai-link at 1 {
+ dai-link-1 {
sound-dai = <&frddr_b>;
};
- dai-link at 2 {
+ dai-link-2 {
sound-dai = <&frddr_c>;
};
- dai-link at 3 {
+ dai-link-3 {
sound-dai = <&toddr_a>;
};
- dai-link at 4 {
+ dai-link-4 {
sound-dai = <&toddr_b>;
};
- dai-link at 5 {
+ dai-link-5 {
sound-dai = <&toddr_c>;
};
- dai-link at 6 {
+ dai-link-6 {
sound-dai = <&tdmif_c>;
dai-format = "i2s";
dai-tdm-slot-tx-mask-2 = <1 1>;
@@ -327,7 +327,7 @@
};
- dai-link at 7 {
+ dai-link-7 {
sound-dai = <&spdifout>;
codec {
@@ -335,7 +335,7 @@
};
};
- dai-link at 8 {
+ dai-link-8 {
sound-dai = <&spdifin>;
codec {
@@ -343,7 +343,7 @@
};
};
- dai-link at 9 {
+ dai-link-9 {
sound-dai = <&pdm>;
codec {
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 8746433c71be..7ab1a627951f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -23,7 +23,7 @@
#address-cells = <2>;
#size-cells = <2>;
- tdmif_a: audio-controller at 0 {
+ tdmif_a: audio-controller-0 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_A";
@@ -34,7 +34,7 @@
status = "disabled";
};
- tdmif_b: audio-controller at 1 {
+ tdmif_b: audio-controller-1 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_B";
@@ -45,7 +45,7 @@
status = "disabled";
};
- tdmif_c: audio-controller at 2 {
+ tdmif_c: audio-controller-2 {
compatible = "amlogic,axg-tdm-iface";
#sound-dai-cells = <0>;
sound-name-prefix = "TDM_C";
--
2.17.2
next reply other threads:[~2018-10-30 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 15:06 Jerome Brunet [this message]
2018-10-30 15:06 ` [PATCH] arm64: dts: meson-axg: fix dtc warning about unit address Jerome Brunet
2018-10-30 15:06 ` Jerome Brunet
2018-11-08 9:51 ` [PATCH RESEND] " Jerome Brunet
2018-11-08 9:51 ` Jerome Brunet
2018-11-08 13:28 ` Neil Armstrong
2018-11-08 13:28 ` Neil Armstrong
2018-11-15 19:49 ` Kevin Hilman
2018-11-15 19:49 ` Kevin Hilman
2018-11-15 19:49 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030150614.19461-1-jbrunet@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=carlo@caione.org \
--cc=festevam@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.