From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
viro@zeniv.linux.org.uk, smfrench@gmail.com, miklos@szeredi.hu
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: [PATCH v8 09/11] NFS: for "inter" copy treat ESTALE as ENOTSUPP
Date: Thu, 1 Nov 2018 12:45:21 -0400 [thread overview]
Message-ID: <20181101164523.41812-10-olga.kornievskaia@gmail.com> (raw)
In-Reply-To: <20181101164523.41812-1-olga.kornievskaia@gmail.com>
From: Olga Kornievskaia <kolga@netapp.com>
If the client sends an "inter" copy to the destination server but
it only supports "intra" copy, it can return ESTALE (since it
doesn't know anything about the file handle from the other server
and does not recognize the special case of "inter" copy). Translate
this error as ENOTSUPP and also send OFFLOAD_CANCEL to the source
server so that it can clean up state.
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
fs/nfs/nfs42proc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index 98fe00b..00809b3 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -395,6 +395,11 @@ ssize_t nfs42_proc_copy(struct file *src, loff_t pos_src,
args.sync = true;
dst_exception.retry = 1;
continue;
+ } else if (err == -ESTALE &&
+ !nfs42_files_from_same_server(src, dst)) {
+ nfs42_do_offload_cancel_async(src, &args.src_stateid);
+ err = -EOPNOTSUPP;
+ break;
}
err2 = nfs4_handle_exception(server, err, &src_exception);
--
1.8.3.1
next prev parent reply other threads:[~2018-11-01 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 16:45 [PATCH v8 00/11] client-side support for "inter" SSC copy Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 01/11] VFS: move cross device copy_file_range() check into filesystems Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 02/11] NFS: validity check for source offset in copy_file_range Olga Kornievskaia
2018-11-01 16:45 ` Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 03/11] NFS NFSD: defining nl4_servers structure needed by both Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 04/11] NFS: add COPY_NOTIFY operation Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 05/11] NFS: add ca_source_server<> to COPY Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 06/11] NFS: also send OFFLOAD_CANCEL to source server Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 07/11] NFS: inter ssc open Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 08/11] NFS: skip recovery of copy open on dest server Olga Kornievskaia
2018-11-01 16:45 ` Olga Kornievskaia [this message]
2018-11-01 16:45 ` [PATCH v8 10/11] NFS: COPY handle ERR_OFFLOAD_DENIED Olga Kornievskaia
2018-11-01 16:45 ` [PATCH v8 11/11] NFS: replace cross device check in copy_file_range Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101164523.41812-10-olga.kornievskaia@gmail.com \
--to=olga.kornievskaia@gmail.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=smfrench@gmail.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.