From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: "rostedt@goodmis.org" <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: [PATCH 3/8] kernel-shark-qt: Put error messages always on top
Date: Thu, 1 Nov 2018 21:45:40 +0000 [thread overview]
Message-ID: <20181101214512.18684-4-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20181101214512.18684-1-ykaradzhov@vmware.com>
When an error message is shown its widget must be placed always on top
of all other windows. Also the user shouldn't be able to do anything
else, before closing the error message widget.
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
kernel-shark-qt/src/KsMainWindow.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel-shark-qt/src/KsMainWindow.cpp b/kernel-shark-qt/src/KsMainWindow.cpp
index b3cbc3b..4f9a6e2 100644
--- a/kernel-shark-qt/src/KsMainWindow.cpp
+++ b/kernel-shark-qt/src/KsMainWindow.cpp
@@ -859,8 +859,9 @@ void KsMainWindow::_error(const QString &text, const QString &errCode,
if (unloadPlugins)
_plugins.unloadAll();
- em->showMessage(text, errCode);
qCritical() << "ERROR: " << text;
+ em->showMessage(text, errCode);
+ em->exec();
}
/**
--
2.17.1
next prev parent reply other threads:[~2018-11-02 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 21:45 [PATCH 0/8] This series of patches contains various independent Yordan Karadzhov
2018-11-01 21:45 ` [PATCH 1/8] kernel-shark-qt: Free all collections when closing the trace file Yordan Karadzhov
2018-11-01 21:45 ` [PATCH 2/8] kernel-shark-qt: Fix potential memory leak when searching in collections Yordan Karadzhov
2018-11-01 21:45 ` Yordan Karadzhov [this message]
2018-11-01 21:45 ` [PATCH 4/8] kernel-shark-qt: Fix bug when loading the Dual Marker Yordan Karadzhov
2018-11-01 21:45 ` [PATCH 5/8] kernel-shark-qt: Fix bug when loading plugins from session Yordan Karadzhov
2018-11-01 21:45 ` [PATCH 6/8] kernel-shark-qt: Fix bug when resizing the KS window for session Yordan Karadzhov
2018-11-01 21:45 ` [PATCH 7/8] kernel-shark-qt: Change the color convention of the task graphs Yordan Karadzhov
2018-11-01 21:45 ` [PATCH 8/8] kernel-shark-qt: Remove duplicate code in KsWidgetsLib.cpp Yordan Karadzhov
2018-11-02 19:16 ` [PATCH 0/8] This series of patches contains various independent Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101214512.18684-4-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.