From: Marc Zyngier <marc.zyngier@arm.com> To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com> Subject: [PATCH 3/4] arm64: KVM: Install stage-2 translation before enabling traps on VHE Date: Mon, 5 Nov 2018 14:36:15 +0000 [thread overview] Message-ID: <20181105143617.120602-4-marc.zyngier@arm.com> (raw) In-Reply-To: <20181105143617.120602-1-marc.zyngier@arm.com> It is a bit odd that we only install stage-2 translation after having cleared HCR_EL2.TGE, which means that there is a window during which AT requests could fail as stage-2 is not configured yet. Let's move stage-2 configuration before we clear TGE, making the guest entry sequence clearer: we first configure all the guest stuff, then only switch to the guest translation regime. Non-VHE doesn't have that kind of behaviour, and is left alone. Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> --- arch/arm64/kvm/hyp/switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c index 7cc175c88a37..51d5d966d9e5 100644 --- a/arch/arm64/kvm/hyp/switch.c +++ b/arch/arm64/kvm/hyp/switch.c @@ -499,8 +499,8 @@ int kvm_vcpu_run_vhe(struct kvm_vcpu *vcpu) sysreg_save_host_state_vhe(host_ctxt); - __activate_traps(vcpu); __activate_vm(vcpu->kvm); + __activate_traps(vcpu); sysreg_restore_guest_state_vhe(guest_ctxt); __debug_switch_to_guest(vcpu); -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/4] arm64: KVM: Install stage-2 translation before enabling traps on VHE Date: Mon, 5 Nov 2018 14:36:15 +0000 [thread overview] Message-ID: <20181105143617.120602-4-marc.zyngier@arm.com> (raw) In-Reply-To: <20181105143617.120602-1-marc.zyngier@arm.com> It is a bit odd that we only install stage-2 translation after having cleared HCR_EL2.TGE, which means that there is a window during which AT requests could fail as stage-2 is not configured yet. Let's move stage-2 configuration before we clear TGE, making the guest entry sequence clearer: we first configure all the guest stuff, then only switch to the guest translation regime. Non-VHE doesn't have that kind of behaviour, and is left alone. Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> --- arch/arm64/kvm/hyp/switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c index 7cc175c88a37..51d5d966d9e5 100644 --- a/arch/arm64/kvm/hyp/switch.c +++ b/arch/arm64/kvm/hyp/switch.c @@ -499,8 +499,8 @@ int kvm_vcpu_run_vhe(struct kvm_vcpu *vcpu) sysreg_save_host_state_vhe(host_ctxt); - __activate_traps(vcpu); __activate_vm(vcpu->kvm); + __activate_traps(vcpu); sysreg_restore_guest_state_vhe(guest_ctxt); __debug_switch_to_guest(vcpu); -- 2.19.1
next prev parent reply other threads:[~2018-11-05 14:36 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-05 14:36 [PATCH 0/4] Workaround for Cortex-A76 erratum 1165522 Marc Zyngier 2018-11-05 14:36 ` Marc Zyngier 2018-11-05 14:36 ` [PATCH 1/4] KVM: arm64: Rework detection of SVE, !VHE systems Marc Zyngier 2018-11-05 14:36 ` Marc Zyngier 2018-11-06 7:52 ` Christoffer Dall 2018-11-06 7:52 ` Christoffer Dall 2018-11-08 19:14 ` Dave Martin 2018-11-08 19:14 ` Dave Martin 2018-11-05 14:36 ` [PATCH 2/4] KVM: arm64: Allow implementations to be confined to using VHE Marc Zyngier 2018-11-05 14:36 ` Marc Zyngier 2018-11-06 7:53 ` Christoffer Dall 2018-11-06 7:53 ` Christoffer Dall 2018-11-08 17:51 ` Marc Zyngier 2018-11-08 17:51 ` Marc Zyngier 2018-11-08 19:23 ` Dave Martin 2018-11-08 19:23 ` Dave Martin 2018-11-05 14:36 ` Marc Zyngier [this message] 2018-11-05 14:36 ` [PATCH 3/4] arm64: KVM: Install stage-2 translation before enabling traps on VHE Marc Zyngier 2018-11-06 8:06 ` Christoffer Dall 2018-11-06 8:06 ` Christoffer Dall 2018-11-08 17:54 ` Marc Zyngier 2018-11-08 17:54 ` Marc Zyngier 2018-11-05 14:36 ` [PATCH 4/4] arm64: KVM: Implement workaround for Cortex-A76 erratum 1165522 Marc Zyngier 2018-11-05 14:36 ` Marc Zyngier 2018-11-05 18:34 ` James Morse 2018-11-05 18:34 ` James Morse 2018-11-08 17:18 ` Marc Zyngier 2018-11-08 17:18 ` Marc Zyngier 2018-11-09 11:39 ` James Morse 2018-11-09 11:39 ` James Morse 2018-11-06 8:15 ` Christoffer Dall 2018-11-06 8:15 ` Christoffer Dall 2018-11-08 18:05 ` Marc Zyngier 2018-11-08 18:05 ` Marc Zyngier 2018-11-08 20:10 ` Christoffer Dall 2018-11-08 20:10 ` Christoffer Dall 2018-11-22 16:13 ` Marc Zyngier 2018-11-22 16:13 ` Marc Zyngier 2018-11-23 9:57 ` Christoffer Dall 2018-11-23 9:57 ` Christoffer Dall 2018-11-21 12:23 ` Julien Grall 2018-11-21 12:23 ` Julien Grall 2018-11-21 12:58 ` Marc Zyngier 2018-11-21 12:58 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181105143617.120602-4-marc.zyngier@arm.com \ --to=marc.zyngier@arm.com \ --cc=catalin.marinas@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.