All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>
Subject: [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo()
Date: Wed, 14 Nov 2018 16:12:14 -0800	[thread overview]
Message-ID: <20181115001214.48210-1-ebiggers@kernel.org> (raw)

From: Eric Biggers <ebiggers@google.com>

inotify_show_fdinfo() is defined in fs/notify/fdinfo.c and declared in
fs/notify/fdinfo.h, but the declaration isn't included at the point of
the definition.  Include the header to enforce that the definition
matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/notify/fdinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 348a184bcdda3..1e2bfd26b3521 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -15,6 +15,7 @@
 #include <linux/exportfs.h>
 
 #include "inotify/inotify.h"
+#include "fdinfo.h"
 #include "fsnotify.h"
 
 #if defined(CONFIG_PROC_FS)
-- 
2.19.1.930.g4563a0d9d0-goog

             reply	other threads:[~2018-11-15 10:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  0:12 Eric Biggers [this message]
2018-11-15 16:35 ` [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo() Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115001214.48210-1-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.