From: Eric Biggers <ebiggers@kernel.org> To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au> Cc: linux-fscrypt@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Crowley <paulcrowley@google.com>, Greg Kaiser <gkaiser@google.com>, "Jason A . Donenfeld" <Jason@zx2c4.com>, Samuel Neves <samuel.c.p.neves@gmail.com>, Tomer Ashur <tomer.ashur@esat.kuleuven.be>, Eric Biggers <ebiggers@google.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Martin Willi <martin@strongswan.org> Subject: [PATCH v4 02/14] crypto: chacha20-generic - don't unnecessarily use atomic walk Date: Fri, 16 Nov 2018 17:26:19 -0800 [thread overview] Message-ID: <20181117012631.23528-3-ebiggers@kernel.org> (raw) In-Reply-To: <20181117012631.23528-1-ebiggers@kernel.org> From: Eric Biggers <ebiggers@google.com> chacha20-generic doesn't use SIMD instructions or otherwise disable preemption, so passing atomic=true to skcipher_walk_virt() is unnecessary. Suggested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Acked-by: Martin Willi <martin@strongswan.org> Signed-off-by: Eric Biggers <ebiggers@google.com> --- crypto/chacha20_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/chacha20_generic.c b/crypto/chacha20_generic.c index 3ae96587caf9..3529521d72a4 100644 --- a/crypto/chacha20_generic.c +++ b/crypto/chacha20_generic.c @@ -81,7 +81,7 @@ int crypto_chacha20_crypt(struct skcipher_request *req) u32 state[16]; int err; - err = skcipher_walk_virt(&walk, req, true); + err = skcipher_walk_virt(&walk, req, false); crypto_chacha20_init(state, ctx, walk.iv); -- 2.19.1.1215.g8438c0b245-goog
WARNING: multiple messages have this Message-ID (diff)
From: ebiggers@kernel.org (Eric Biggers) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 02/14] crypto: chacha20-generic - don't unnecessarily use atomic walk Date: Fri, 16 Nov 2018 17:26:19 -0800 [thread overview] Message-ID: <20181117012631.23528-3-ebiggers@kernel.org> (raw) In-Reply-To: <20181117012631.23528-1-ebiggers@kernel.org> From: Eric Biggers <ebiggers@google.com> chacha20-generic doesn't use SIMD instructions or otherwise disable preemption, so passing atomic=true to skcipher_walk_virt() is unnecessary. Suggested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Acked-by: Martin Willi <martin@strongswan.org> Signed-off-by: Eric Biggers <ebiggers@google.com> --- crypto/chacha20_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/chacha20_generic.c b/crypto/chacha20_generic.c index 3ae96587caf9..3529521d72a4 100644 --- a/crypto/chacha20_generic.c +++ b/crypto/chacha20_generic.c @@ -81,7 +81,7 @@ int crypto_chacha20_crypt(struct skcipher_request *req) u32 state[16]; int err; - err = skcipher_walk_virt(&walk, req, true); + err = skcipher_walk_virt(&walk, req, false); crypto_chacha20_init(state, ctx, walk.iv); -- 2.19.1.1215.g8438c0b245-goog
next prev parent reply other threads:[~2018-11-17 11:43 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-17 1:26 [PATCH v4 00/14] crypto: Adiantum support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 01/14] crypto: chacha20-generic - add HChaCha20 library function Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` Eric Biggers [this message] 2018-11-17 1:26 ` [PATCH v4 02/14] crypto: chacha20-generic - don't unnecessarily use atomic walk Eric Biggers 2018-11-17 1:26 ` [PATCH v4 03/14] crypto: chacha20-generic - add XChaCha20 support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 04/14] crypto: chacha20-generic - refactor to allow varying number of rounds Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 05/14] crypto: chacha - add XChaCha12 support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 06/14] crypto: arm/chacha20 - limit the preemption-disabled section Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 07/14] crypto: arm/chacha20 - add XChaCha20 support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 08/14] crypto: arm/chacha20 - refactor to allow varying number of rounds Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 09/14] crypto: arm/chacha - add XChaCha12 support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:26 ` [PATCH v4 10/14] crypto: poly1305 - use structures for key and accumulator Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:43 ` Ard Biesheuvel 2018-11-17 1:43 ` Ard Biesheuvel 2018-11-17 1:43 ` Ard Biesheuvel 2018-11-17 1:26 ` [PATCH v4 11/14] crypto: poly1305 - add Poly1305 core API Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:50 ` Ard Biesheuvel 2018-11-17 1:50 ` Ard Biesheuvel 2018-11-17 1:50 ` Ard Biesheuvel 2018-11-17 1:26 ` [PATCH v4 12/14] crypto: nhpoly1305 - add NHPoly1305 support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 1:52 ` Ard Biesheuvel 2018-11-17 1:52 ` Ard Biesheuvel 2018-11-17 1:52 ` Ard Biesheuvel 2018-11-17 1:26 ` [PATCH v4 13/14] crypto: arm/nhpoly1305 - add NEON-accelerated NHPoly1305 Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 2:00 ` Ard Biesheuvel 2018-11-17 2:00 ` Ard Biesheuvel 2018-11-17 2:00 ` Ard Biesheuvel 2018-11-17 1:26 ` [PATCH v4 14/14] crypto: adiantum - add Adiantum support Eric Biggers 2018-11-17 1:26 ` Eric Biggers 2018-11-17 2:03 ` Ard Biesheuvel 2018-11-17 2:03 ` Ard Biesheuvel 2018-11-17 2:03 ` Ard Biesheuvel 2018-11-20 6:33 ` [PATCH v4 00/14] crypto: " Herbert Xu 2018-11-20 6:33 ` Herbert Xu 2018-11-30 17:58 ` Eric Biggers 2018-11-30 17:58 ` Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181117012631.23528-3-ebiggers@kernel.org \ --to=ebiggers@kernel.org \ --cc=Jason@zx2c4.com \ --cc=ard.biesheuvel@linaro.org \ --cc=ebiggers@google.com \ --cc=gkaiser@google.com \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=martin@strongswan.org \ --cc=paulcrowley@google.com \ --cc=samuel.c.p.neves@gmail.com \ --cc=tomer.ashur@esat.kuleuven.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.