From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs: reflink should flush after an unaligned directio cow write
Date: Tue, 20 Nov 2018 17:17:06 -0800 [thread overview]
Message-ID: <20181121011706.GO6792@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
If userspace hands us a not-block-aligned directio write, we'll fall
back to a buffered write for the read-modify-write operation.
Unfortunately, we don't flush the page cache after a successful
fallback CoW, which means we break userspace's expectation that the data
has been sent to the drive. Fix that by upgrading the iocb to DSYNC so
that the buffered CoW is synchronous.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_file.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index e47425071e65..675da7e9c001 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -692,6 +692,8 @@ xfs_file_write_iter(
struct xfs_inode *ip = XFS_I(inode);
ssize_t ret;
size_t ocount = iov_iter_count(from);
+ bool was_dsync = iocb->ki_flags & IOCB_DSYNC;
+ int error;
XFS_STATS_INC(ip->i_mount, xs_write_calls);
@@ -714,9 +716,13 @@ xfs_file_write_iter(
ret = xfs_file_dio_aio_write(iocb, from);
if (ret != -EREMCHG)
return ret;
+ iocb->ki_flags |= IOCB_DSYNC;
}
- return xfs_file_buffered_aio_write(iocb, from);
+ error = xfs_file_buffered_aio_write(iocb, from);
+ if (!was_dsync)
+ iocb->ki_flags &= ~IOCB_DSYNC;
+ return error;
}
static void
next reply other threads:[~2018-11-21 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 1:17 Darrick J. Wong [this message]
2018-11-21 16:30 ` [PATCH] xfs: reflink should flush after an unaligned directio cow write Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121011706.GO6792@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.