From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, muhammad_bilal@mentor.com,
frederic.konrad@adacore.com, alistair@alistair23.me,
philmd@redhat.com, frasse.iglesias@gmail.com,
figlesia@xilinx.com, sstabellini@kernel.org,
sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com
Subject: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()
Date: Fri, 23 Nov 2018 14:54:50 +0100 [thread overview]
Message-ID: <20181123135450.24829-2-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <20181123135450.24829-1-edgar.iglesias@gmail.com>
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Don't assert on RX descriptor settings when the receiver is
disabled. This fixes an issue with incoming packets on an
unused GEM.
Reported-by: mbilal <muhammad_bilal@mentor.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/net/cadence_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index d95cc27f58..7f63411430 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -979,7 +979,6 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
/* Do nothing if receive is not enabled. */
if (!gem_can_receive(nc)) {
- assert(!first_desc);
return -1;
}
--
2.17.1
next prev parent reply other threads:[~2018-11-23 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 13:54 [Qemu-devel] [PATCH v1 0/1] net: cadence_gem: Remove incorrect assert() Edgar E. Iglesias
2018-11-23 13:54 ` Edgar E. Iglesias [this message]
2018-11-23 16:46 ` [Qemu-devel] [PATCH v1 1/1] " Philippe Mathieu-Daudé
2018-11-23 16:59 ` Edgar E. Iglesias
2018-11-23 17:02 ` Edgar E. Iglesias
2018-11-23 17:06 ` Edgar E. Iglesias
2018-11-23 18:22 ` Philippe Mathieu-Daudé
2018-11-23 17:09 ` Peter Maydell
2018-11-26 12:52 ` Edgar E. Iglesias
2018-11-26 13:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123135450.24829-2-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=muhammad_bilal@mentor.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.