All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Applied "ASoC: audio-graph-scu-card: tidyup "prefix" parsing" to the asoc tree
Date: Fri, 23 Nov 2018 14:12:18 +0000 (GMT)	[thread overview]
Message-ID: <20181123141218.D804A440078@finisterre.ee.mobilebroadband> (raw)
In-Reply-To: <87tvkalz05.wl-kuninori.morimoto.gx@renesas.com>

The patch

   ASoC: audio-graph-scu-card: tidyup "prefix" parsing

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 2624fc7882244abeb4dabbd5b67328676a109b6a Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Thu, 22 Nov 2018 00:56:21 +0000
Subject: [PATCH] ASoC: audio-graph-scu-card: tidyup "prefix" parsing

audio-graph-scu-card.c is supporting "prefix" which is used to avoid
DAI naming conflict when CPU/Codec matching.
But, sound card might have multi sub-devices, and each codec might need
each prefix.

Now, ASoC is supporting snd_soc_of_parse_node_prefix(), let's support
it on audio-graph-scu-card, too. It is keeping existing DT style.

It can't support each codec's prefix if sound card had multi sub-devices
without this patch.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/generic/audio-graph-scu-card.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c
index c46947393f80..fdc61f1c1d79 100644
--- a/sound/soc/generic/audio-graph-scu-card.c
+++ b/sound/soc/generic/audio-graph-scu-card.c
@@ -39,6 +39,8 @@ struct graph_card_data {
 #define graph_priv_to_dev(priv) (graph_priv_to_card(priv)->dev)
 #define graph_priv_to_link(priv, i) (graph_priv_to_card(priv)->dai_link + (i))
 
+#define PREFIX	"audio-graph-card,"
+
 static int asoc_graph_card_startup(struct snd_pcm_substream *substream)
 {
 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
@@ -98,6 +100,7 @@ static int asoc_graph_card_dai_link_of(struct device_node *ep,
 	struct snd_soc_dai_link *dai_link = graph_priv_to_link(priv, idx);
 	struct graph_dai_props *dai_props = graph_priv_to_props(priv, idx);
 	struct snd_soc_card *card = graph_priv_to_card(priv);
+	struct device_node *node = of_graph_get_port_parent(ep);
 	int ret;
 
 	if (is_fe) {
@@ -154,10 +157,17 @@ static int asoc_graph_card_dai_link_of(struct device_node *ep,
 		if (ret < 0)
 			return ret;
 
+		/* check "prefix" from top node */
 		snd_soc_of_parse_audio_prefix(card,
 					      &priv->codec_conf,
 					      dai_link->codecs->of_node,
 					      "prefix");
+		/* check "prefix" from each node if top doesn't have */
+		if (!priv->codec_conf.of_node)
+			snd_soc_of_parse_node_prefix(node,
+						     &priv->codec_conf,
+						     dai_link->codecs->of_node,
+						     PREFIX "prefix");
 	}
 
 	ret = asoc_simple_card_of_parse_tdm(ep, &dai_props->dai);
-- 
2.19.1

  reply	other threads:[~2018-11-23 14:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22  0:54 [PATCH 00/10] ASoC: merge audio-graph-scu into audio-graph - step2 Kuninori Morimoto
2018-11-22  0:55 ` [PATCH 01/10] ASoC: soc-core: add snd_soc_of_parse_node_prefix() Kuninori Morimoto
2018-11-23 13:53   ` Mark Brown
2018-11-26  0:07     ` Kuninori Morimoto
2018-11-23 14:13   ` Applied "ASoC: soc-core: add snd_soc_of_parse_node_prefix()" to the asoc tree Mark Brown
2018-11-22  0:55 ` [PATCH 02/10] ASoC: simple-scu-card: tidyup "prefix" parsing on Doc Kuninori Morimoto
2018-11-23 14:12   ` Applied "ASoC: simple-scu-card: tidyup "prefix" parsing on Doc" to the asoc tree Mark Brown
2018-11-22  0:55 ` [PATCH 03/10] ASoC: simple-scu-card: tidyup "prefix" parsing Kuninori Morimoto
2018-11-23 14:12   ` Applied "ASoC: simple-scu-card: tidyup "prefix" parsing" to the asoc tree Mark Brown
2018-11-22  0:55 ` [PATCH 04/10] ASoC: audio-graph-scu-card: tidyup "prefix" parsing on Doc Kuninori Morimoto
2018-11-23 14:12   ` Applied "ASoC: audio-graph-scu-card: tidyup "prefix" parsing on Doc" to the asoc tree Mark Brown
2018-11-22  0:56 ` [PATCH 05/10] ASoC: audio-graph-scu-card: tidyup "prefix" parsing Kuninori Morimoto
2018-11-23 14:12   ` Mark Brown [this message]
2018-11-22  0:56 ` [PATCH 06/10] ASoC: audio-graph-scu-card: tidyup "convert-rate/channels" parsing on Doc Kuninori Morimoto
2018-11-23 14:12   ` Applied "ASoC: audio-graph-scu-card: tidyup "convert-rate/channels" parsing on Doc" to the asoc tree Mark Brown
2018-11-22  0:56 ` [PATCH 07/10] ASoC: audio-graph-scu-card: tidyup "convert-rate/channels" parsing Kuninori Morimoto
2018-11-23 14:11   ` Applied "ASoC: audio-graph-scu-card: tidyup "convert-rate/channels" parsing" to the asoc tree Mark Brown
2018-11-22  0:57 ` [PATCH 08/10] ASoC: audio-graph-scu-card: tidyup asoc_simple_card_parse_daifmt() timing Kuninori Morimoto
2018-11-23 14:11   ` Applied "ASoC: audio-graph-scu-card: tidyup asoc_simple_card_parse_daifmt() timing" to the asoc tree Mark Brown
2018-11-22  0:57 ` [PATCH 09/10] ASoC: audio-graph-card: tidyup typo SND_AUDIO_GRAPH_CARD Kuninori Morimoto
2018-11-23 14:11   ` Applied "ASoC: audio-graph-card: tidyup typo SND_AUDIO_GRAPH_CARD" to the asoc tree Mark Brown
2018-11-22  0:57 ` [PATCH 10/10] ASoC: audio-graph-card: tidyup define position Kuninori Morimoto
2018-11-23 14:11   ` Applied "ASoC: audio-graph-card: tidyup define position" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123141218.D804A440078@finisterre.ee.mobilebroadband \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.