All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hsin-Yi, Wang" <hsinyi@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] usb/mtu3: power down device ip at setup
Date: Wed, 28 Nov 2018 14:04:12 +0800	[thread overview]
Message-ID: <20181128060412.630-1-hsinyi@chromium.org> (raw)

Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip,
so host ip sleep will fail at ssusb_host_disable.

Power down device ip at ssusb_host_setup.

Signed-off-by: Hsin-Yi, Wang <hsinyi@chromium.org>
---
 drivers/usb/mtu3/mtu3_host.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c
index c871b94f3e6f..d17cf43305db 100644
--- a/drivers/usb/mtu3/mtu3_host.c
+++ b/drivers/usb/mtu3/mtu3_host.c
@@ -192,9 +192,17 @@ int ssusb_host_disable(struct ssusb_mtk *ssusb, bool suspend)
 static void ssusb_host_setup(struct ssusb_mtk *ssusb)
 {
 	struct otg_switch_mtk *otg_sx = &ssusb->otg_switch;
+	void __iomem *ibase = ssusb->ippc_base;
 
 	host_ports_num_get(ssusb);
 
+	/*
+	 * device ip is default power-on in fact
+	 * power down device ip, otherwise ip-sleep will fail
+	 */
+	if (ssusb->dr_mode == USB_DR_MODE_HOST)
+		mtu3_setbits(ibase, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN);
+
 	/*
 	 * power on host and power on/enable all ports
 	 * if support OTG, gadget driver will switch port0 to device mode
-- 
2.18.1


WARNING: multiple messages have this Message-ID (diff)
From: "Hsin-Yi, Wang" <hsinyi@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: usb/mtu3: power down device ip at setup
Date: Wed, 28 Nov 2018 14:04:12 +0800	[thread overview]
Message-ID: <20181128060412.630-1-hsinyi@chromium.org> (raw)

Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip,
so host ip sleep will fail at ssusb_host_disable.

Power down device ip at ssusb_host_setup.

Signed-off-by: Hsin-Yi, Wang <hsinyi@chromium.org>
---
 drivers/usb/mtu3/mtu3_host.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c
index c871b94f3e6f..d17cf43305db 100644
--- a/drivers/usb/mtu3/mtu3_host.c
+++ b/drivers/usb/mtu3/mtu3_host.c
@@ -192,9 +192,17 @@ int ssusb_host_disable(struct ssusb_mtk *ssusb, bool suspend)
 static void ssusb_host_setup(struct ssusb_mtk *ssusb)
 {
 	struct otg_switch_mtk *otg_sx = &ssusb->otg_switch;
+	void __iomem *ibase = ssusb->ippc_base;
 
 	host_ports_num_get(ssusb);
 
+	/*
+	 * device ip is default power-on in fact
+	 * power down device ip, otherwise ip-sleep will fail
+	 */
+	if (ssusb->dr_mode == USB_DR_MODE_HOST)
+		mtu3_setbits(ibase, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN);
+
 	/*
 	 * power on host and power on/enable all ports
 	 * if support OTG, gadget driver will switch port0 to device mode

WARNING: multiple messages have this Message-ID (diff)
From: hsinyi@chromium.org (Hsin-Yi, Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb/mtu3: power down device ip at setup
Date: Wed, 28 Nov 2018 14:04:12 +0800	[thread overview]
Message-ID: <20181128060412.630-1-hsinyi@chromium.org> (raw)

Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip,
so host ip sleep will fail at ssusb_host_disable.

Power down device ip at ssusb_host_setup.

Signed-off-by: Hsin-Yi, Wang <hsinyi@chromium.org>
---
 drivers/usb/mtu3/mtu3_host.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c
index c871b94f3e6f..d17cf43305db 100644
--- a/drivers/usb/mtu3/mtu3_host.c
+++ b/drivers/usb/mtu3/mtu3_host.c
@@ -192,9 +192,17 @@ int ssusb_host_disable(struct ssusb_mtk *ssusb, bool suspend)
 static void ssusb_host_setup(struct ssusb_mtk *ssusb)
 {
 	struct otg_switch_mtk *otg_sx = &ssusb->otg_switch;
+	void __iomem *ibase = ssusb->ippc_base;
 
 	host_ports_num_get(ssusb);
 
+	/*
+	 * device ip is default power-on in fact
+	 * power down device ip, otherwise ip-sleep will fail
+	 */
+	if (ssusb->dr_mode == USB_DR_MODE_HOST)
+		mtu3_setbits(ibase, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN);
+
 	/*
 	 * power on host and power on/enable all ports
 	 * if support OTG, gadget driver will switch port0 to device mode
-- 
2.18.1

             reply	other threads:[~2018-11-28  6:04 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  6:04 Hsin-Yi, Wang [this message]
2018-11-28  6:04 ` [PATCH] usb/mtu3: power down device ip at setup Hsin-Yi, Wang
2018-11-28  6:04 ` Hsin-Yi, Wang
2018-11-28  6:22 ` [PATCH] " Chunfeng Yun
2018-11-28  6:22   ` Chunfeng Yun
2018-11-28  6:22   ` Chunfeng Yun
2018-11-28  6:22   ` Chunfeng Yun
2018-11-28  6:59   ` [PATCH] " Hsin-Yi Wang
2018-11-28  6:59     ` Hsin-Yi Wang
2018-11-28  6:59     ` Hsin-Yi, Wang
     [not found]   ` <CAJMQK-joY4M-=4+XoYAC5SJUie554i_EO=7VgrkJj2JNbbDdxg@mail.gmail.com>
2018-11-28  7:02     ` [PATCH] " Chunfeng Yun
2018-11-28  7:02       ` Chunfeng Yun
2018-11-28  7:02       ` Chunfeng Yun
2018-11-28  7:02       ` Chunfeng Yun
2018-11-28  9:29 ` [V2] " Hsin-Yi, Wang
2018-11-28  9:29   ` Hsin-Yi, Wang
2018-11-28  9:29   ` Hsin-Yi, Wang
2018-11-28  9:41   ` Chunfeng Yun
2018-11-28  9:41     ` Chunfeng Yun
2018-11-28  9:41     ` Chunfeng Yun
2018-11-28  9:41     ` Chunfeng Yun
2018-11-28  9:53   ` [V3] " Hsin-Yi, Wang
2018-11-28  9:53     ` Hsin-Yi, Wang
2018-11-28  9:53     ` Hsin-Yi, Wang
2018-11-29  1:20     ` Nicolas Boichat
2018-11-29  1:20       ` Nicolas Boichat
2018-11-29  1:20       ` Nicolas Boichat
2018-11-29  3:16     ` [PATCH v4] " Hsin-Yi, Wang
2018-11-29  3:16       ` Hsin-Yi, Wang
2018-11-29  3:16       ` [v4] " Hsin-Yi, Wang
2018-11-29  6:26       ` [PATCH v4] " Chunfeng Yun
2018-11-29  6:26         ` Chunfeng Yun
2018-11-29  6:26         ` Chunfeng Yun
2018-11-29  6:26         ` [v4] " Chunfeng Yun
2018-11-29  7:50         ` [PATCH v4] " Hsin-Yi Wang
2018-11-29  7:50           ` Hsin-Yi Wang
2018-11-29  7:50           ` [v4] " Hsin-Yi, Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128060412.630-1-hsinyi@chromium.org \
    --to=hsinyi@chromium.org \
    --cc=chunfeng.yun@mediatek.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.