All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: mhocko@suse.com, akpm@linux-foundation.org, jweiner@fb.com
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH v2] mm, show_mem: drop pgdat_resize_lock in show_mem()
Date: Fri, 30 Nov 2018 07:55:32 +0800	[thread overview]
Message-ID: <20181129235532.9328-1-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20181128210815.2134-1-richard.weiyang@gmail.com>

Function show_mem() is used to print system memory status when user
requires or fail to allocate memory. Generally, this is a best effort
information so any races with memory hotplug (or very theoretically an
early initialization) should be tolerable and the worst that could
happen is to print an imprecise node state.

Drop the resize lock because this is the only place which might hold the
lock from the interrupt context and so all other callers might use a
simple spinlock. Even though this doesn't solve any real issue it makes
the code easier to follow and tiny more effective.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

---
v2:
   * adjust the changelog to show the reason of this change
   * remove unused variable flags
---
 lib/show_mem.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/show_mem.c b/lib/show_mem.c
index 0beaa1d899aa..f4e029e1ddec 100644
--- a/lib/show_mem.c
+++ b/lib/show_mem.c
@@ -18,10 +18,8 @@ void show_mem(unsigned int filter, nodemask_t *nodemask)
 	show_free_areas(filter, nodemask);
 
 	for_each_online_pgdat(pgdat) {
-		unsigned long flags;
 		int zoneid;
 
-		pgdat_resize_lock(pgdat, &flags);
 		for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
 			struct zone *zone = &pgdat->node_zones[zoneid];
 			if (!populated_zone(zone))
@@ -33,7 +31,6 @@ void show_mem(unsigned int filter, nodemask_t *nodemask)
 			if (is_highmem_idx(zoneid))
 				highmem += zone->present_pages;
 		}
-		pgdat_resize_unlock(pgdat, &flags);
 	}
 
 	printk("%lu pages RAM\n", total);
-- 
2.15.1

  parent reply	other threads:[~2018-11-29 23:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 21:08 [PATCH] mm, show_mem: drop pgdat_resize_lock in show_mem() Wei Yang
2018-11-28 22:07 ` Andrew Morton
2018-11-29  1:52   ` Wei Yang
2018-11-29  8:17 ` Michal Hocko
2018-11-29  9:32   ` Wei Yang
2018-11-29 15:04   ` Wei Yang
2018-11-29 15:49     ` Michal Hocko
2018-11-29 16:05       ` Wei Yang
2018-11-29 16:18         ` Michal Hocko
2018-11-29 23:49           ` Wei Yang
2018-11-29 23:55 ` Wei Yang [this message]
2018-11-30  8:17   ` [PATCH v2] " Michal Hocko
2018-11-30  8:54   ` osalvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129235532.9328-1-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jweiner@fb.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.