All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: architt@codeaurora.org, a.hajda@samsung.com,
	Laurent.pinchart@ideasonboard.com
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH RFC v2 2/8] drm/meson: add HDMI div40 TMDS mode
Date: Fri, 30 Nov 2018 14:42:55 +0100	[thread overview]
Message-ID: <20181130134301.17963-3-narmstrong@baylibre.com> (raw)
In-Reply-To: <20181130134301.17963-1-narmstrong@baylibre.com>

Add support for TMDS Clock > 3.4GHz for HDMI2.0 display modes.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index 807111ebfdd9..b8775102b100 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -365,7 +365,8 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
 	unsigned int wr_clk =
 		readl_relaxed(priv->io_base + _REG(VPU_HDMI_SETTING));
 
-	DRM_DEBUG_DRIVER("%d:\"%s\"\n", mode->base.id, mode->name);
+	DRM_DEBUG_DRIVER("%d:\"%s\" div%d\n", mode->base.id, mode->name,
+			 mode->clock > 340000 ? 40 : 10);
 
 	/* Enable clocks */
 	regmap_update_bits(priv->hhi, HHI_HDMI_CLK_CNTL, 0xffff, 0x100);
@@ -385,9 +386,17 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
 	/* Enable normal output to PHY */
 	dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_BIST_CNTL, BIT(12));
 
-	/* TMDS pattern setup (TOFIX pattern for 4k2k scrambling) */
-	dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, 0x001f001f);
-	dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23, 0x001f001f);
+	/* TMDS pattern setup (TOFIX Handle the YUV420 case) */
+	if (mode->clock > 340000) {
+		dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, 0);
+		dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23,
+				  0x03ff03ff);
+	} else {
+		dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01,
+				  0x001f001f);
+		dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23,
+				  0x001f001f);
+	}
 
 	/* Load TMDS pattern */
 	dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_CNTL, 0x1);
@@ -413,6 +422,8 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
 	/* Disable clock, fifo, fifo_wr */
 	regmap_update_bits(priv->hhi, HHI_HDMI_PHY_CNTL1, 0xf, 0);
 
+	dw_hdmi_set_high_tmds_clock_ratio(hdmi);
+
 	msleep(100);
 
 	/* Reset PHY 3 times in a row */
@@ -562,6 +573,11 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
 		mode->vdisplay, mode->vsync_start,
 		mode->vsync_end, mode->vtotal, mode->type, mode->flags);
 
+	/* If sink max TMDS clock < 340MHz, we reject the HDMI2.0 modes */
+	if (mode->clock > 340000 &&
+	    connector->display_info.max_tmds_clock < 340000)
+		return MODE_BAD;
+
 	/* Check against non-VIC supported modes */
 	if (!vic) {
 		status = meson_venc_hdmi_supported_mode(mode);
-- 
2.19.2


  parent reply	other threads:[~2018-11-30 13:43 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 13:42 [PATCH RFC v2 0/8] drm/meson: Add support for HDMI2.0 4k60 Neil Armstrong
2018-11-30 13:42 ` [PATCH RFC v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support Neil Armstrong
2018-11-30 13:42   ` Neil Armstrong
2018-12-14 12:12   ` Heiko Stuebner
2018-12-14 12:12     ` Heiko Stuebner
2018-12-14 12:12     ` Heiko Stuebner
2018-12-18 12:25   ` Andrzej Hajda
2018-12-18 12:25     ` Andrzej Hajda
2018-12-18 12:25     ` Andrzej Hajda
2018-12-18 13:17     ` Neil Armstrong
2018-12-18 13:17       ` Neil Armstrong
2018-12-18 13:17       ` Neil Armstrong
2018-11-30 13:42 ` Neil Armstrong [this message]
2018-12-18 12:36   ` [PATCH RFC v2 2/8] drm/meson: add HDMI div40 TMDS mode Andrzej Hajda
2018-12-18 12:36     ` Andrzej Hajda
2018-12-18 12:36     ` Andrzej Hajda
2018-12-18 13:19     ` Neil Armstrong
2018-12-18 13:19       ` Neil Armstrong
2018-12-18 13:19       ` Neil Armstrong
2018-11-30 13:42 ` [PATCH RFC v2 3/8] drm/meson: add support for HDMI2.0 2160p modes Neil Armstrong
2018-11-30 13:42   ` Neil Armstrong
2018-12-18 12:37   ` Andrzej Hajda
2018-12-18 12:37     ` Andrzej Hajda
2018-11-30 13:42 ` [PATCH RFC v2 4/8] drm/bridge: dw-hdmi: add support for YUV420 output Neil Armstrong
2018-12-14 12:13   ` Heiko Stuebner
2018-12-14 12:13     ` Heiko Stuebner
2018-12-14 12:13     ` Heiko Stuebner
2018-12-18 13:41   ` Andrzej Hajda
2018-12-18 13:41     ` Andrzej Hajda
2018-11-30 13:42 ` [PATCH RFC v2 5/8] drm/bridge: dw-hdmi: support dynamically get input/out color info Neil Armstrong
2018-12-14 12:13   ` Heiko Stuebner
2018-12-14 12:13     ` Heiko Stuebner
2018-12-14 12:13     ` Heiko Stuebner
2018-12-19  7:26   ` Andrzej Hajda
2018-12-19  7:26     ` Andrzej Hajda
2018-12-19  7:50     ` Laurent Pinchart
2018-12-19  7:50       ` Laurent Pinchart
2018-12-19  7:50       ` Laurent Pinchart
2018-12-20  7:37       ` Neil Armstrong
2018-12-20  7:37         ` Neil Armstrong
2018-12-20  7:37         ` Neil Armstrong
2018-11-30 13:42 ` [PATCH RFC v2 6/8] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a Neil Armstrong
2018-12-14 12:13   ` Heiko Stuebner
2018-12-14 12:13     ` Heiko Stuebner
2018-12-14 12:13     ` Heiko Stuebner
2018-11-30 13:43 ` [PATCH RFC v2 7/8] drm/meson: Add YUV420 output support Neil Armstrong
2018-11-30 13:43 ` [PATCH RFC v2 8/8] drm/meson: Output in YUV444 if sink supports it Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181130134301.17963-3-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=architt@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.