All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 7/9] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3
Date: Thu,  6 Dec 2018 10:37:25 +0100	[thread overview]
Message-ID: <20181206093727.16792-7-christian.koenig@amd.com> (raw)
In-Reply-To: <20181206093727.16792-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>

Implement finding the right timeline point in drm_syncobj_find_fence.

v2: return -EINVAL when the point is not submitted yet.
v3: fix reference counting bug, add flags handling as well

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/drm_syncobj.c | 43 ++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index 1d830760992b..54fd7e34ceae 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -231,16 +231,53 @@ int drm_syncobj_find_fence(struct drm_file *file_private,
 			   struct dma_fence **fence)
 {
 	struct drm_syncobj *syncobj = drm_syncobj_find(file_private, handle);
-	int ret = 0;
+	struct syncobj_wait_entry wait;
+	int ret;
 
 	if (!syncobj)
 		return -ENOENT;
 
 	*fence = drm_syncobj_fence_get(syncobj);
-	if (!*fence) {
+	drm_syncobj_put(syncobj);
+
+	if (*fence) {
+		ret = dma_fence_chain_find_seqno(fence, point);
+		if (!ret)
+			return 0;
+		dma_fence_put(*fence);
+	} else {
 		ret = -EINVAL;
 	}
-	drm_syncobj_put(syncobj);
+
+	if (!(flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT))
+		return ret;
+
+	memset(&wait, 0, sizeof(wait));
+	wait.task = current;
+	wait.point = point;
+	drm_syncobj_fence_add_wait(syncobj, &wait);
+
+	do {
+		set_current_state(TASK_INTERRUPTIBLE);
+		if (wait.fence) {
+			ret = 0;
+			break;
+		}
+
+		if (signal_pending(current)) {
+			ret = -ERESTARTSYS;
+			break;
+		}
+
+		schedule();
+	} while (1);
+
+	__set_current_state(TASK_RUNNING);
+	*fence = wait.fence;
+
+	if (wait.node.next)
+		drm_syncobj_remove_wait(syncobj, &wait);
+
 	return ret;
 }
 EXPORT_SYMBOL(drm_syncobj_find_fence);
-- 
2.14.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-12-06  9:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06  9:37 [PATCH 1/9] dma-buf: make fence sequence numbers 64 bit v2 Christian König
2018-12-06  9:37 ` [PATCH 4/9] drm/syncobj: add new drm_syncobj_add_point interface v2 Christian König
     [not found] ` <20181206093727.16792-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-12-06  9:37   ` [PATCH 2/9] dma-buf: add new dma_fence_chain container v4 Christian König
2018-12-06  9:37   ` [PATCH 3/9] drm/syncobj: remove drm_syncobj_cb and cleanup Christian König
2018-12-06  9:37   ` [PATCH 5/9] drm/syncobj: add support for timeline point wait v8 Christian König
2018-12-06  9:37   ` [PATCH 6/9] drm/syncobj: add timeline payload query ioctl v4 Christian König
2018-12-06  9:37   ` Christian König [this message]
2018-12-06  9:37 ` [PATCH 8/9] drm/amdgpu: add timeline support in amdgpu CS v2 Christian König
2018-12-06  9:37 ` [PATCH 9/9] drm/amdgpu: update version for timeline syncobj support in amdgpu Christian König
  -- strict thread matches above, loose matches on Subject: below --
2018-12-05 13:08 [PATCH 1/9] dma-buf: make fence sequence numbers 64 bit v2 Christian König
     [not found] ` <20181205130835.1595-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-12-05 13:08   ` [PATCH 7/9] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3 Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206093727.16792-7-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.