From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/3] drm/i915/ringbuffer: EMIT_INVALIDATE after switch context
Date: Fri, 7 Dec 2018 09:02:12 +0000 [thread overview]
Message-ID: <20181207090213.14352-2-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20181207090213.14352-1-chris@chris-wilson.co.uk>
The recommend procedure was to switch contexts (and mm) then invalidate
the TLBs. Make it so.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 16084749adf5..74a4d587c312 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1827,12 +1827,12 @@ static int ring_request_alloc(struct i915_request *request)
*/
request->reserved_space += LEGACY_REQUEST_SIZE;
- /* Unconditionally invalidate GPU caches and TLBs. */
- ret = request->engine->emit_flush(request, EMIT_INVALIDATE);
+ ret = switch_context(request);
if (ret)
return ret;
- ret = switch_context(request);
+ /* Unconditionally invalidate GPU caches and TLBs. */
+ ret = request->engine->emit_flush(request, EMIT_INVALIDATE);
if (ret)
return ret;
--
2.20.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-07 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 9:02 [PATCH 1/3] drm/i915: Push EMIT_INVALIDATE at request start to backends Chris Wilson
2018-12-07 9:02 ` Chris Wilson [this message]
2018-12-07 10:25 ` [PATCH 2/3] drm/i915/ringbuffer: EMIT_INVALIDATE after switch context Tvrtko Ursulin
2018-12-07 9:02 ` [PATCH 3/3] drm/i915: Pipeline PDP updates for Braswell Chris Wilson
2018-12-07 10:30 ` Tvrtko Ursulin
2018-12-07 10:39 ` Chris Wilson
2018-12-07 10:22 ` [PATCH 1/3] drm/i915: Push EMIT_INVALIDATE at request start to backends Tvrtko Ursulin
2018-12-07 11:28 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2018-12-07 13:34 ` Chris Wilson
2018-12-07 17:25 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207090213.14352-2-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.