From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Greg Kurz <groug@kaod.org>, Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>,
Collin Walling <walling@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Pierre Morel <pmorel@linux.ibm.com>,
qemu-ppc@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v4 00/11] pci: hotplug handler reworks
Date: Wed, 12 Dec 2018 10:16:12 +0100 [thread overview]
Message-ID: <20181212091623.16950-1-david@redhat.com> (raw)
This is a resend with added RB's. @MST please pick up :)
This series reworks some pci hotplug handlers (except for s390, that will
require more work but is not required for now).
1. Route all unplug calls via the hotplug handler when called from the
unplug_request handler. This will be required to get multi-stage
hotplug handlers running, but also makes sense on its own (just like we
already did for some CPU/memory hotplug handlers).
2. Introduce some pre_plug handlers where it makes sense already.
3. Call the plug/pre_plug handler also for coldplugged devices. Especially
pcihp is special as it overwrites hotplug handlers.
This series will not yet factor out pre_plug/plug/unplug from pci device
realize/unrealize functions, this will require more work but this
series is also required first to get it running.
In my opinion what needs to be done in the future:
1. Introduce pre_plug/plug/unplug_request/unplug handlers for all PCI
buses
2. Move pci realize/unrealize parts to pre_plug/pkug/unplug functions like
pci_pre_plug() ...
3. Call the pci pre_plug/plug/unplug handlers from the PCI bus hotplug
handler at the right spots
4. Factor more checks from existing plug() handlers out into pre_plug()
(e.g. after the call to pci_pre_plug())
v3 -> v4:
- RB's added
v2 -> v3:
- Added "pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge"
-- Use one handler callback for pcie and !pcie
- "pci/shpc: perform unplug via the hotplug handler"
-- Use one handler callback for pcie and !pcie
-- Replace error check by an assertion
- Minor description changes.
- Added Rbs
v1 -> v2:
- Added "pci/pcie: rename hotplug handler callbacks"
- Added "pci/shpc: rename hotplug handler callbacks"
- Added "s390x/pci: rename hotplug handler callbacks"
- Dropped "pci/shpc: move hotplug checks to preplug handler"
-- We will have to factor out stuff into pre_plug() first as described
above
- Renamed and added more details to the "perform unplug via the hotplug
handler" patches
- "pci/pcihp: overwrite hotplug handler recursively from the start"
-- Perform the overwrite only for cold plugged bridges, to keep the
existing behavior
David Hildenbrand (11):
pci/pcie: rename hotplug handler callbacks
pci/shpc: rename hotplug handler callbacks
s390x/pci: rename hotplug handler callbacks
pci/pcie: stop plug/unplug if the slot is locked
pci/pcihp: perform check for bus capability in pre_plug handler
pci/pcihp: overwrite hotplug handler recursively from the start
pci/pcihp: perform unplug via the hotplug handler
pci/pcie: perform unplug via the hotplug handler
pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge
pci/shpc: perform unplug via the hotplug handler
spapr_pci: perform unplug via the hotplug handler
hw/acpi/pcihp.c | 47 ++++++++++++++++++++++++++++-----
hw/acpi/piix4.c | 39 ++++++++++++++-------------
hw/pci-bridge/pci_bridge_dev.c | 31 ++++++++++++++--------
hw/pci-bridge/pcie_pci_bridge.c | 32 +++-------------------
hw/pci/pcie.c | 46 +++++++++++++++++++++-----------
hw/pci/pcie_port.c | 6 +++--
hw/pci/shpc.c | 25 ++++++++++++------
hw/ppc/spapr_pci.c | 33 ++++++++++++++---------
hw/s390x/s390-pci-bus.c | 12 ++++-----
include/hw/acpi/pcihp.h | 5 ++++
include/hw/pci/pci_bridge.h | 6 +++++
include/hw/pci/pcie.h | 12 ++++++---
include/hw/pci/shpc.h | 10 ++++---
13 files changed, 187 insertions(+), 117 deletions(-)
--
2.17.2
next reply other threads:[~2018-12-12 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 9:16 David Hildenbrand [this message]
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 01/11] pci/pcie: rename hotplug handler callbacks David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 02/11] pci/shpc: " David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 03/11] s390x/pci: " David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 04/11] pci/pcie: stop plug/unplug if the slot is locked David Hildenbrand
2019-01-07 12:13 ` David Hildenbrand
2019-01-08 0:14 ` Michael S. Tsirkin
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 05/11] pci/pcihp: perform check for bus capability in pre_plug handler David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 06/11] pci/pcihp: overwrite hotplug handler recursively from the start David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 07/11] pci/pcihp: perform unplug via the hotplug handler David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 08/11] pci/pcie: " David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 09/11] pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge David Hildenbrand
2018-12-12 23:57 ` David Gibson
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 10/11] pci/shpc: perform unplug via the hotplug handler David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 11/11] spapr_pci: " David Hildenbrand
2018-12-17 13:46 ` [Qemu-devel] [PATCH v4 00/11] pci: hotplug handler reworks David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212091623.16950-1-david@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.