All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [RESEND PATCH 3/5] drm/i915: Enable fastset for non-boot modesets.
Date: Mon, 17 Dec 2018 10:50:22 +0100	[thread overview]
Message-ID: <20181217095024.2340-3-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20181217095024.2340-1-maarten.lankhorst@linux.intel.com>

Now that our state comparison functions are pretty complete, we should
enable fastset by default when a modeset can be avoided. Even if we're
not completely certain about the inherited state, we can be certain
after the first modeset that our sw state matches the hw state.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 86e7b145fd98..2dd99e5437a5 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11651,6 +11651,11 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,
 		(current_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
 		!(pipe_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
 
+	if (fixup_inherited && !i915_modparams.fastboot) {
+		drm_dbg(DRM_UT_KMS, "initial modeset and fastboot not set\n");
+		ret = false;
+	}
+
 #define PIPE_CONF_CHECK_X(name) do { \
 	if (current_config->name != pipe_config->name) { \
 		pipe_config_err(adjust, __stringify(name), \
@@ -12674,8 +12679,7 @@ static int intel_atomic_check(struct drm_device *dev,
 			return ret;
 		}
 
-		if (i915_modparams.fastboot &&
-		    intel_pipe_config_compare(dev_priv,
+		if (intel_pipe_config_compare(dev_priv,
 					to_intel_crtc_state(old_crtc_state),
 					pipe_config, true)) {
 			crtc_state->mode_changed = false;
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-12-17  9:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17  9:50 [RESEND PATCH 1/5] drm/i915/backlight: Restore backlight on resume, v2 Maarten Lankhorst
2018-12-17  9:50 ` [RESEND PATCH 2/5] drm/i915/backlight: Fix backlight takeover on LPT, v2 Maarten Lankhorst
2018-12-18  9:49   ` [HACK for CI] drm/i915: Update crtc scaler settings when update_pipe is set Maarten Lankhorst
2018-12-28 14:45   ` [RESEND PATCH 2/5] drm/i915/backlight: Fix backlight takeover on LPT, v2 Jani Nikula
2018-12-17  9:50 ` Maarten Lankhorst [this message]
2018-12-18 16:00   ` [RESEND, 3/5] drm/i915: Enable fastset for non-boot modesets Hans de Goede
2018-12-17  9:50 ` [PATCH 4/5] drm/i915: Make HW readout mark CRTC scaler as in use Maarten Lankhorst
2018-12-18 16:01   ` [4/5] " Hans de Goede
2018-12-17  9:50 ` [RESEND PATCH 5/5] drm/i915: Re-enable fastset by default Maarten Lankhorst
2018-12-17 10:32 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight on resume, v2 Patchwork
2018-12-17 10:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-12-17 10:49 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-17 12:50 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-12-18 10:02 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight on resume, v2. (rev2) Patchwork
2018-12-18 10:28 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-18 11:38 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-12-21 13:57 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight on resume, v2. (rev3) Patchwork
2018-12-21 14:17 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-12-21 15:11 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight on resume, v2. (rev4) Patchwork
2018-12-21 15:29 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-12-21 18:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight on resume, v2. (rev5) Patchwork
2018-12-21 18:59 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-21 23:53 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-28 10:10 ` [RESEND PATCH 1/5] drm/i915/backlight: Restore backlight on resume, v2 Jani Nikula
2019-01-02 10:14   ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217095024.2340-3-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.