All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <architt@codeaurora.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	dri-devel@lists.freedesktop.org,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: [PATCHv2 1/7] drm/bridge: tc358767: add bus flags
Date: Thu, 3 Jan 2019 13:59:48 +0200	[thread overview]
Message-ID: <20190103115954.12785-2-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com>

tc358767 driver does not set DRM bus_flags, even if it does configures
the polarity settings into its registers. This means that the DPI source
can't configure the polarities correctly.

Add sync flags accordingly.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/bridge/tc358767.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 8e28e738cb52..29a7e33e8ae0 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -1195,6 +1195,10 @@ static int tc_bridge_attach(struct drm_bridge *bridge)
 
 	drm_display_info_set_bus_formats(&tc->connector.display_info,
 					 &bus_format, 1);
+	tc->connector.display_info.bus_flags =
+		DRM_BUS_FLAG_DE_HIGH |
+		DRM_BUS_FLAG_PIXDATA_NEGEDGE |
+		DRM_BUS_FLAG_SYNC_NEGEDGE;
 	drm_connector_attach_encoder(&tc->connector, tc->bridge.encoder);
 
 	return 0;
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-01-03 12:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190103120053epcas2p2901389967dc032aa2587c2a291d44c9f@epcas2p2.samsung.com>
2019-01-03 11:59 ` [PATCHv2 0/7] drm/bridge: tc358767: small fixes Tomi Valkeinen
2019-01-03 11:59   ` Tomi Valkeinen [this message]
2019-01-03 11:59   ` [PATCHv2 2/7] drm/bridge: tc358767: add defines for DP1_SRCCTRL & PHY_2LANE Tomi Valkeinen
2019-01-03 11:59   ` [PATCHv2 3/7] drm/bridge: tc358767: fix single lane configuration Tomi Valkeinen
2019-01-03 11:59   ` [PATCHv2 4/7] drm/bridge: tc358767: fix initial DP0/1_SRCCTRL value Tomi Valkeinen
2019-01-03 11:59   ` [PATCHv2 5/7] drm/bridge: tc358767: reject modes which require too much BW Tomi Valkeinen
2019-01-03 11:59   ` [PATCHv2 6/7] drm/bridge: tc358767: fix output H/V syncs Tomi Valkeinen
2019-01-03 11:59   ` [PATCHv2 7/7] drm/bridge: tc358767: use DP connector if no panel set Tomi Valkeinen
2019-01-09  8:22   ` [PATCHv2 0/7] drm/bridge: tc358767: small fixes Andrzej Hajda
2019-01-09  9:12     ` Tomi Valkeinen
2019-01-09  9:51       ` Lucas Stach
2019-01-09 10:12         ` Andrzej Hajda
2019-01-23 12:52           ` Tomi Valkeinen
2019-01-23 14:39             ` A H
2019-01-09 14:55         ` Tomi Valkeinen
2019-01-09 14:58           ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103115954.12785-2-tomi.valkeinen@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=architt@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.