All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-block@nongnu.org, Julio Faracco <jcfaracco@gmail.com>,
	yuchenlin <yuchenlin@synology.com>
Subject: [Qemu-devel] [PULL 1/4] dmg: Fixing wrong dmg block type value for block terminator.
Date: Fri,  4 Jan 2019 11:21:42 +0000	[thread overview]
Message-ID: <20190104112145.12413-2-stefanha@redhat.com> (raw)
In-Reply-To: <20190104112145.12413-1-stefanha@redhat.com>

From: Julio Faracco <jcfaracco@gmail.com>

This is a trivial patch to fix a wrong value for block terminator.
The old value was 0x7fffffff which is wrong. It was not affecting the
code because QEMU dmg block is not handling block terminator right now.
Neverthless, it should be fixed.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Reviewed-by: yuchenlin <yuchenlin@synology.com>
Message-id: 20181228145055.18039-1-jcfaracco@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/dmg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/dmg.c b/block/dmg.c
index 50e91aef6d..2c806e3389 100644
--- a/block/dmg.c
+++ b/block/dmg.c
@@ -54,7 +54,7 @@ enum {
     UDBZ,
     ULFO,
     UDCM = 0x7ffffffe, /* Comments */
-    UDLE               /* Last Entry */
+    UDLE = 0xffffffff  /* Last Entry */
 };
 
 static int dmg_probe(const uint8_t *buf, int buf_size, const char *filename)
-- 
2.20.1

  reply	other threads:[~2019-01-04 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 11:21 [Qemu-devel] [PULL 0/4] Block patches Stefan Hajnoczi
2019-01-04 11:21 ` Stefan Hajnoczi [this message]
2019-01-04 11:21 ` [Qemu-devel] [PULL 2/4] dmg: fix binary search Stefan Hajnoczi
2019-01-04 11:21 ` [Qemu-devel] [PULL 3/4] dmg: use enumeration type instead of hard coding number Stefan Hajnoczi
2019-01-04 11:21 ` [Qemu-devel] [PULL 4/4] dmg: don't skip zero chunk Stefan Hajnoczi
2019-01-04 14:54 ` [Qemu-devel] [PULL 0/4] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104112145.12413-2-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=jcfaracco@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yuchenlin@synology.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.