All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Lubomir Rintel <lkundrak@v3.sk>
Subject: [PATCH v5 05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks
Date: Thu, 10 Jan 2019 18:58:40 +0100	[thread overview]
Message-ID: <20190110175845.1203986-6-lkundrak@v3.sk> (raw)
In-Reply-To: <20190110175845.1203986-1-lkundrak@v3.sk>

Just a cosmetic tidy-up.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

---
Changes since v1:
- This patch was added to the set.

 include/linux/olpc-ec.h | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
index 7fa3d27f7fee..f7b6a7eda232 100644
--- a/include/linux/olpc-ec.h
+++ b/include/linux/olpc-ec.h
@@ -2,6 +2,8 @@
 #ifndef _LINUX_OLPC_EC_H
 #define _LINUX_OLPC_EC_H
 
+#include <linux/bits.h>
+
 /* XO-1 EC commands */
 #define EC_FIRMWARE_REV			0x08
 #define EC_WRITE_SCI_MASK		0x1b
@@ -17,17 +19,16 @@
 #define EC_EXT_SCI_QUERY		0x85
 
 /* SCI source values */
-#define EC_SCI_SRC_EMPTY        0x00
-#define EC_SCI_SRC_GAME         0x01
-#define EC_SCI_SRC_BATTERY      0x02
-#define EC_SCI_SRC_BATSOC       0x04
-#define EC_SCI_SRC_BATERR       0x08
-#define EC_SCI_SRC_EBOOK        0x10    /* XO-1 only */
-#define EC_SCI_SRC_WLAN         0x20    /* XO-1 only */
-#define EC_SCI_SRC_ACPWR        0x40
-#define EC_SCI_SRC_BATCRIT      0x80
-#define EC_SCI_SRC_GPWAKE       0x100   /* XO-1.5 only */
-#define EC_SCI_SRC_ALL          0x1FF
+#define EC_SCI_SRC_GAME         BIT(0)
+#define EC_SCI_SRC_BATTERY      BIT(1)
+#define EC_SCI_SRC_BATSOC       BIT(2)
+#define EC_SCI_SRC_BATERR       BIT(3)
+#define EC_SCI_SRC_EBOOK        BIT(4)    /* XO-1 only */
+#define EC_SCI_SRC_WLAN         BIT(5)    /* XO-1 only */
+#define EC_SCI_SRC_ACPWR        BIT(6)
+#define EC_SCI_SRC_BATCRIT      BIT(7)
+#define EC_SCI_SRC_GPWAKE       BIT(8)   /* XO-1.5 only */
+#define EC_SCI_SRC_ALL          GENMASK(8, 0)
 
 struct platform_device;
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak@v3.sk>
To: Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	platform-driver-x86@vger.kernel.org,
	Lubomir Rintel <lkundrak@v3.sk>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks
Date: Thu, 10 Jan 2019 18:58:40 +0100	[thread overview]
Message-ID: <20190110175845.1203986-6-lkundrak@v3.sk> (raw)
In-Reply-To: <20190110175845.1203986-1-lkundrak@v3.sk>

Just a cosmetic tidy-up.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

---
Changes since v1:
- This patch was added to the set.

 include/linux/olpc-ec.h | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
index 7fa3d27f7fee..f7b6a7eda232 100644
--- a/include/linux/olpc-ec.h
+++ b/include/linux/olpc-ec.h
@@ -2,6 +2,8 @@
 #ifndef _LINUX_OLPC_EC_H
 #define _LINUX_OLPC_EC_H
 
+#include <linux/bits.h>
+
 /* XO-1 EC commands */
 #define EC_FIRMWARE_REV			0x08
 #define EC_WRITE_SCI_MASK		0x1b
@@ -17,17 +19,16 @@
 #define EC_EXT_SCI_QUERY		0x85
 
 /* SCI source values */
-#define EC_SCI_SRC_EMPTY        0x00
-#define EC_SCI_SRC_GAME         0x01
-#define EC_SCI_SRC_BATTERY      0x02
-#define EC_SCI_SRC_BATSOC       0x04
-#define EC_SCI_SRC_BATERR       0x08
-#define EC_SCI_SRC_EBOOK        0x10    /* XO-1 only */
-#define EC_SCI_SRC_WLAN         0x20    /* XO-1 only */
-#define EC_SCI_SRC_ACPWR        0x40
-#define EC_SCI_SRC_BATCRIT      0x80
-#define EC_SCI_SRC_GPWAKE       0x100   /* XO-1.5 only */
-#define EC_SCI_SRC_ALL          0x1FF
+#define EC_SCI_SRC_GAME         BIT(0)
+#define EC_SCI_SRC_BATTERY      BIT(1)
+#define EC_SCI_SRC_BATSOC       BIT(2)
+#define EC_SCI_SRC_BATERR       BIT(3)
+#define EC_SCI_SRC_EBOOK        BIT(4)    /* XO-1 only */
+#define EC_SCI_SRC_WLAN         BIT(5)    /* XO-1 only */
+#define EC_SCI_SRC_ACPWR        BIT(6)
+#define EC_SCI_SRC_BATCRIT      BIT(7)
+#define EC_SCI_SRC_GPWAKE       BIT(8)   /* XO-1.5 only */
+#define EC_SCI_SRC_ALL          GENMASK(8, 0)
 
 struct platform_device;
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-10 17:59 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 17:58 [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-01-10 17:58 ` Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 01/10] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings Lubomir Rintel
2019-01-10 17:58   ` [PATCH v5 01/10] dt-bindings: olpc, xo1.75-ec: " Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-11 14:36   ` [PATCH v5 01/10] dt-bindings: olpc,xo1.75-ec: " Rob Herring
2019-01-11 14:36     ` Rob Herring
2019-01-11 14:36     ` Rob Herring
2019-02-21  1:21     ` Darren Hart
2019-02-21  1:21       ` Darren Hart
2019-02-21  1:21       ` Darren Hart
2019-01-10 17:58 ` [PATCH v5 02/10] Platform: OLPC: Remove an unused include Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 03/10] Platform: OLPC: Move EC-specific functionality out from x86 Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 04/10] Platform: OLPC: Avoid a warning if the EC didn't register yet Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-10 17:58 ` Lubomir Rintel [this message]
2019-01-10 17:58   ` [PATCH v5 05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-02-21  1:22   ` Darren Hart
2019-02-21  1:22     ` Darren Hart
2019-02-21  1:22     ` Darren Hart
2019-02-21 13:28     ` Andy Shevchenko
2019-02-21 13:28       ` Andy Shevchenko
2019-02-21 13:28       ` Andy Shevchenko
2019-01-10 17:58 ` [PATCH v5 07/10] Platform: OLPC: Add a regulator for the DCON Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 08/10] power: supply: olpc_battery: Allow building the driver on non-x86 Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-02-19 23:17   ` Sebastian Reichel
2019-02-19 23:17     ` Sebastian Reichel
2019-01-10 17:58 ` [PATCH v5 09/10] ARM: export arm_pm_restart Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 10/10] Platform: OLPC: Add restart support to XO-1.75 EC driver Lubomir Rintel
2019-01-10 17:58   ` Lubomir Rintel
2019-02-11 11:46 ` [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-02-11 11:46   ` Lubomir Rintel
2019-02-11 11:49   ` Andy Shevchenko
2019-02-11 11:49     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110175845.1203986-6-lkundrak@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=andy@infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dvhart@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.