All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Chen-Yu Tsai <wens@csie.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <sean@poorly.run>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: [PATCH RESEND v5 03/23] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check
Date: Fri, 18 Jan 2019 15:51:13 +0100	[thread overview]
Message-ID: <20190118145133.21281-4-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20190118145133.21281-1-paul.kocialkowski@bootlin.com>

Checking for the number of planes is not sufficient to en ensure that
the format is a packed YUV422.

Use explicit fourcc helpers for the check instead.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/gpu/drm/sun4i/sun4i_backend.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 9e9255ee59cd..bbadc2ab9f4d 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -245,7 +245,8 @@ static int sun4i_backend_update_yuv_format(struct sun4i_backend *backend,
 			   SUN4I_BACKEND_ATTCTL_REG0_LAY_YUVEN);
 
 	/* TODO: Add support for the multi-planar YUV formats */
-	if (format->num_planes == 1)
+	if (drm_format_info_is_yuv_packed(format) &&
+	    drm_format_info_is_yuv_sampling_422(format))
 		val |= SUN4I_BACKEND_IYUVCTL_FBFMT_PACKED_YUV422;
 	else
 		DRM_DEBUG_DRIVER("Unsupported YUV format (0x%x)\n", fmt);
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
	Daniel Vetter <daniel@ffwll.ch>, Sean Paul <sean@poorly.run>
Subject: [PATCH RESEND v5 03/23] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check
Date: Fri, 18 Jan 2019 15:51:13 +0100	[thread overview]
Message-ID: <20190118145133.21281-4-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20190118145133.21281-1-paul.kocialkowski@bootlin.com>

Checking for the number of planes is not sufficient to en ensure that
the format is a packed YUV422.

Use explicit fourcc helpers for the check instead.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/gpu/drm/sun4i/sun4i_backend.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 9e9255ee59cd..bbadc2ab9f4d 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -245,7 +245,8 @@ static int sun4i_backend_update_yuv_format(struct sun4i_backend *backend,
 			   SUN4I_BACKEND_ATTCTL_REG0_LAY_YUVEN);
 
 	/* TODO: Add support for the multi-planar YUV formats */
-	if (format->num_planes == 1)
+	if (drm_format_info_is_yuv_packed(format) &&
+	    drm_format_info_is_yuv_sampling_422(format))
 		val |= SUN4I_BACKEND_IYUVCTL_FBFMT_PACKED_YUV422;
 	else
 		DRM_DEBUG_DRIVER("Unsupported YUV format (0x%x)\n", fmt);
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: Maxime Ripard
	<maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Maarten Lankhorst
	<maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>,
	Thomas Petazzoni
	<thomas.petazzoni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
	Paul Kocialkowski
	<paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH RESEND v5 03/23] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check
Date: Fri, 18 Jan 2019 15:51:13 +0100	[thread overview]
Message-ID: <20190118145133.21281-4-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20190118145133.21281-1-paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>

Checking for the number of planes is not sufficient to en ensure that
the format is a packed YUV422.

Use explicit fourcc helpers for the check instead.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Acked-by: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
---
 drivers/gpu/drm/sun4i/sun4i_backend.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 9e9255ee59cd..bbadc2ab9f4d 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -245,7 +245,8 @@ static int sun4i_backend_update_yuv_format(struct sun4i_backend *backend,
 			   SUN4I_BACKEND_ATTCTL_REG0_LAY_YUVEN);
 
 	/* TODO: Add support for the multi-planar YUV formats */
-	if (format->num_planes == 1)
+	if (drm_format_info_is_yuv_packed(format) &&
+	    drm_format_info_is_yuv_sampling_422(format))
 		val |= SUN4I_BACKEND_IYUVCTL_FBFMT_PACKED_YUV422;
 	else
 		DRM_DEBUG_DRIVER("Unsupported YUV format (0x%x)\n", fmt);
-- 
2.20.1

  parent reply	other threads:[~2019-01-18 14:53 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 14:51 [PATCH RESEND v5 00/23] drm/sun4i: Support for linear and tiled YUV formats with the frontend Paul Kocialkowski
2019-01-18 14:51 ` Paul Kocialkowski
2019-01-18 14:51 ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 01/23] drm/fourcc: Add format info helpers for checking YUV planes disposition Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 02/23] drm/fourcc: Add format info helpers for checking YUV sub-sampling Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` Paul Kocialkowski [this message]
2019-01-18 14:51   ` [PATCH RESEND v5 03/23] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 04/23] drm/sun4i: frontend: Pass DRM format info to input format helpers Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 05/23] drm/sun4i: frontend: Determine input format based on colorspace Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 06/23] drm/sun4i: Move the BT.601 CSC coefficients to the frontend Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 07/23] drm/sun4i: frontend: Configure and enable YUV to RGB CSC when needed Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 08/23] drm/sun4i: frontend: Add support for packed YUV422 input formats Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 09/23] drm/sun4i: frontend: Add support for semi-planar YUV " Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 10/23] drm/sun4i: frontend: Add support for planar " Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 11/23] drm/fourcc: Add definitions for Allwinner vendor and VPU tiled format Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 12/23] drm/sun4i: frontend: Add support for tiled YUV input mode configuration Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 13/23] drm/sun4i: Add buffer stride and offset configuration for tiling mode Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 14/23] drm/sun4i: frontend: Add and use helper for checking tiling support Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 15/23] drm/sun4i: layer: Add tiled modifier support and helper Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 16/23] drm/sun4i: drv: Allow framebuffer modifiers in mode config Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 17/23] drm/sun4i: Move access control before setting the register as documented Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 18/23] drm/sun4i: frontend: Add a quirk structure Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 19/23] drm/sun4i: Set the coef_rdy bit right after the coef have been set Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 20/23] drm/sun4i: Make COEF_RDY conditional Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 21/23] drm/sun4i: frontend: Move the FIR filter phases to our quirks Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 22/23] drm/sun4i: frontend: Hook-in support for the A10, with specific quirks Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 23/23] drm/sun4i: frontend: Hook-in support for the A20 Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 14:51   ` Paul Kocialkowski
2019-01-18 18:20 ` [PATCH RESEND v5 00/23] drm/sun4i: Support for linear and tiled YUV formats with the frontend Maxime Ripard
2019-01-18 18:20   ` Maxime Ripard
2019-01-22 10:09   ` Paul Kocialkowski
2019-01-22 10:09     ` Paul Kocialkowski
2019-01-22 10:09     ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118145133.21281-4-paul.kocialkowski@bootlin.com \
    --to=paul.kocialkowski@bootlin.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.