From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH 3/7] HID: input: fix mapping of aspect ratio key
Date: Fri, 18 Jan 2019 15:30:33 -0800 [thread overview]
Message-ID: <20190118233037.87318-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20190118233037.87318-1-dmitry.torokhov@gmail.com>
According to HUTRR37 usage 0x6d from the consumer usage page corresponds
to action that selects the next available supported aspect ratio option
on a device which outputs or displays video. However KEY_ZOOM means
activate "Full Screen" mode, KEY_ASPECT_RATIO should be used instead.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/hid/hid-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index d6fab5798487..def58c6aa835 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -891,7 +891,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
case 0x06a: map_key_clear(KEY_GREEN); break;
case 0x06b: map_key_clear(KEY_BLUE); break;
case 0x06c: map_key_clear(KEY_YELLOW); break;
- case 0x06d: map_key_clear(KEY_ZOOM); break;
+ case 0x06d: map_key_clear(KEY_ASPECT_RATIO); break;
case 0x06f: map_key_clear(KEY_BRIGHTNESSUP); break;
case 0x070: map_key_clear(KEY_BRIGHTNESSDOWN); break;
--
2.20.1.321.g9e740568ce-goog
next prev parent reply other threads:[~2019-01-18 23:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 23:30 [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 2/7] [media] doc-rst: switch to new names for Full Screen/Aspect keys Dmitry Torokhov
2019-02-18 7:26 ` Dmitry Torokhov
2019-03-21 12:20 ` Mauro Carvalho Chehab
2019-01-18 23:30 ` Dmitry Torokhov [this message]
2019-01-18 23:30 ` [PATCH 4/7] HID: input: add mapping for Expose/Overview key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 5/7] HID: input: add mapping for keyboard Brightness Up/Down/Toggle keys Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 6/7] HID: input: add mapping for "Full Screen" key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 7/7] HID: input: add mapping for "Toggle Display" key Dmitry Torokhov
2019-01-21 10:11 ` [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Jiri Kosina
2019-01-21 10:41 ` Benjamin Tissoires
2019-01-23 22:07 ` Dmitry Torokhov
2019-03-21 12:17 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118233037.87318-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.