From: Cornelia Huck <cohuck@redhat.com> To: Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, Pierre Morel <pmorel@linux.ibm.com> Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, qemu-devel@nongnu.org, qemu-s390x@nongnu.org Subject: [PATCH v3 0/6] vfio-ccw: support hsch/csch (kernel part) Date: Wed, 30 Jan 2019 14:22:06 +0100 [thread overview] Message-ID: <20190130132212.7376-1-cohuck@redhat.com> (raw) [This is the Linux kernel part, git tree is available at https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git vfio-ccw-eagain-caps-v3 The companion QEMU patches are available at https://github.com/cohuck/qemu vfio-ccw-caps This is the previously posted v2 version, which should continue to work.] Currently, vfio-ccw only relays START SUBCHANNEL requests to the real device. This tends to work well for the most common 'good path' scenarios; however, as we emulate {HALT,CLEAR} SUBCHANNEL in QEMU, things like clearing pending requests at the device is currently not supported. This may be a problem for e.g. error recovery. This patch series introduces capabilities (similar to what vfio-pci uses) and exposes a new async region for handling hsch/csch. Lightly tested (I can interact with a dasd as before, and reserve/release seems to work well.) Not sure if there is a better way to test this, ideas welcome. Changes v2->v3: - Unb0rked patch 1, improved scope - Split out the new mutex from patch 2 into new patch 3; added missing locking and hopefully improved description - Patch 2 now reworks the state handling by splitting the BUSY state into CP_PROCESSING and CP_PENDING - Patches 3 and 5 adapted on top of the reworked patches; hsch/csch are allowed in CP_PENDING, but not in CP_PROCESSING (did not add any R-b due to that) - Added missing free in patch 5 - Probably some small changes I forgot to note down Changes v1->v2: - New patch 1: make it safe to use the cp accessors at any time; this should avoid problems with unsolicited interrupt handling - New patch 2: handle concurrent accesses to the io region; the idea is to return -EAGAIN to userspace more often (so it can simply retry) - also handle concurrent accesses to the async io region - change VFIO_REGION_TYPE_CCW - merge events for halt and clear to a single async event; this turned out to make the code quite a bit simpler - probably some small changes I forgot to note down Cornelia Huck (6): vfio-ccw: make it safe to access channel programs vfio-ccw: rework ssch state handling vfio-ccw: protect the I/O region vfio-ccw: add capabilities chain s390/cio: export hsch to modules vfio-ccw: add handling for async channel instructions drivers/s390/cio/Makefile | 3 +- drivers/s390/cio/ioasm.c | 1 + drivers/s390/cio/vfio_ccw_async.c | 88 ++++++++++++ drivers/s390/cio/vfio_ccw_cp.c | 20 ++- drivers/s390/cio/vfio_ccw_cp.h | 2 + drivers/s390/cio/vfio_ccw_drv.c | 57 ++++++-- drivers/s390/cio/vfio_ccw_fsm.c | 143 ++++++++++++++++++- drivers/s390/cio/vfio_ccw_ops.c | 210 +++++++++++++++++++++++----- drivers/s390/cio/vfio_ccw_private.h | 48 ++++++- include/uapi/linux/vfio.h | 4 + include/uapi/linux/vfio_ccw.h | 12 ++ 11 files changed, 531 insertions(+), 57 deletions(-) create mode 100644 drivers/s390/cio/vfio_ccw_async.c -- 2.17.2
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com> To: Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, Pierre Morel <pmorel@linux.ibm.com> Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, Cornelia Huck <cohuck@redhat.com> Subject: [Qemu-devel] [PATCH v3 0/6] vfio-ccw: support hsch/csch (kernel part) Date: Wed, 30 Jan 2019 14:22:06 +0100 [thread overview] Message-ID: <20190130132212.7376-1-cohuck@redhat.com> (raw) [This is the Linux kernel part, git tree is available at https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git vfio-ccw-eagain-caps-v3 The companion QEMU patches are available at https://github.com/cohuck/qemu vfio-ccw-caps This is the previously posted v2 version, which should continue to work.] Currently, vfio-ccw only relays START SUBCHANNEL requests to the real device. This tends to work well for the most common 'good path' scenarios; however, as we emulate {HALT,CLEAR} SUBCHANNEL in QEMU, things like clearing pending requests at the device is currently not supported. This may be a problem for e.g. error recovery. This patch series introduces capabilities (similar to what vfio-pci uses) and exposes a new async region for handling hsch/csch. Lightly tested (I can interact with a dasd as before, and reserve/release seems to work well.) Not sure if there is a better way to test this, ideas welcome. Changes v2->v3: - Unb0rked patch 1, improved scope - Split out the new mutex from patch 2 into new patch 3; added missing locking and hopefully improved description - Patch 2 now reworks the state handling by splitting the BUSY state into CP_PROCESSING and CP_PENDING - Patches 3 and 5 adapted on top of the reworked patches; hsch/csch are allowed in CP_PENDING, but not in CP_PROCESSING (did not add any R-b due to that) - Added missing free in patch 5 - Probably some small changes I forgot to note down Changes v1->v2: - New patch 1: make it safe to use the cp accessors at any time; this should avoid problems with unsolicited interrupt handling - New patch 2: handle concurrent accesses to the io region; the idea is to return -EAGAIN to userspace more often (so it can simply retry) - also handle concurrent accesses to the async io region - change VFIO_REGION_TYPE_CCW - merge events for halt and clear to a single async event; this turned out to make the code quite a bit simpler - probably some small changes I forgot to note down Cornelia Huck (6): vfio-ccw: make it safe to access channel programs vfio-ccw: rework ssch state handling vfio-ccw: protect the I/O region vfio-ccw: add capabilities chain s390/cio: export hsch to modules vfio-ccw: add handling for async channel instructions drivers/s390/cio/Makefile | 3 +- drivers/s390/cio/ioasm.c | 1 + drivers/s390/cio/vfio_ccw_async.c | 88 ++++++++++++ drivers/s390/cio/vfio_ccw_cp.c | 20 ++- drivers/s390/cio/vfio_ccw_cp.h | 2 + drivers/s390/cio/vfio_ccw_drv.c | 57 ++++++-- drivers/s390/cio/vfio_ccw_fsm.c | 143 ++++++++++++++++++- drivers/s390/cio/vfio_ccw_ops.c | 210 +++++++++++++++++++++++----- drivers/s390/cio/vfio_ccw_private.h | 48 ++++++- include/uapi/linux/vfio.h | 4 + include/uapi/linux/vfio_ccw.h | 12 ++ 11 files changed, 531 insertions(+), 57 deletions(-) create mode 100644 drivers/s390/cio/vfio_ccw_async.c -- 2.17.2
next reply other threads:[~2019-01-30 13:22 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-30 13:22 Cornelia Huck [this message] 2019-01-30 13:22 ` [Qemu-devel] [PATCH v3 0/6] vfio-ccw: support hsch/csch (kernel part) Cornelia Huck 2019-01-30 13:22 ` [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs Cornelia Huck 2019-01-30 13:22 ` [Qemu-devel] " Cornelia Huck 2019-01-30 18:51 ` Halil Pasic 2019-01-30 18:51 ` [Qemu-devel] " Halil Pasic 2019-01-31 11:52 ` Cornelia Huck 2019-01-31 11:52 ` [Qemu-devel] " Cornelia Huck 2019-01-31 12:34 ` Halil Pasic 2019-01-31 12:34 ` [Qemu-devel] " Halil Pasic 2019-02-04 15:31 ` Cornelia Huck 2019-02-04 15:31 ` [Qemu-devel] " Cornelia Huck 2019-02-05 11:52 ` Halil Pasic 2019-02-05 11:52 ` [Qemu-devel] " Halil Pasic 2019-02-05 12:35 ` Cornelia Huck 2019-02-05 12:35 ` [Qemu-devel] " Cornelia Huck 2019-02-05 14:48 ` Eric Farman 2019-02-05 14:48 ` [Qemu-devel] " Eric Farman 2019-02-05 15:14 ` Farhan Ali 2019-02-05 15:14 ` [Qemu-devel] " Farhan Ali 2019-02-05 16:13 ` Cornelia Huck 2019-02-05 16:13 ` [Qemu-devel] " Cornelia Huck 2019-02-04 19:25 ` Eric Farman 2019-02-04 19:25 ` [Qemu-devel] " Eric Farman 2019-02-05 12:03 ` Cornelia Huck 2019-02-05 12:03 ` [Qemu-devel] " Cornelia Huck 2019-02-05 14:41 ` Eric Farman 2019-02-05 14:41 ` [Qemu-devel] " Eric Farman 2019-02-05 16:29 ` Cornelia Huck 2019-02-05 16:29 ` [Qemu-devel] " Cornelia Huck 2019-01-30 13:22 ` [PATCH v3 2/6] vfio-ccw: rework ssch state handling Cornelia Huck 2019-01-30 13:22 ` [Qemu-devel] " Cornelia Huck 2019-02-04 21:29 ` Eric Farman 2019-02-04 21:29 ` [Qemu-devel] " Eric Farman 2019-02-05 12:10 ` Cornelia Huck 2019-02-05 12:10 ` [Qemu-devel] " Cornelia Huck 2019-02-05 14:31 ` Eric Farman 2019-02-05 14:31 ` [Qemu-devel] " Eric Farman 2019-02-05 16:32 ` Cornelia Huck 2019-02-05 16:32 ` [Qemu-devel] " Cornelia Huck 2019-01-30 13:22 ` [PATCH v3 3/6] vfio-ccw: protect the I/O region Cornelia Huck 2019-01-30 13:22 ` [Qemu-devel] " Cornelia Huck 2019-02-08 21:26 ` Eric Farman 2019-02-08 21:26 ` [Qemu-devel] " Eric Farman 2019-02-11 15:57 ` Cornelia Huck 2019-02-11 15:57 ` [Qemu-devel] " Cornelia Huck 2019-01-30 13:22 ` [PATCH v3 4/6] vfio-ccw: add capabilities chain Cornelia Huck 2019-01-30 13:22 ` [Qemu-devel] " Cornelia Huck 2019-02-15 15:46 ` Eric Farman 2019-02-15 15:46 ` [Qemu-devel] " Eric Farman 2019-02-19 11:06 ` Cornelia Huck 2019-02-19 11:06 ` [Qemu-devel] " Cornelia Huck 2019-01-30 13:22 ` [PATCH v3 5/6] s390/cio: export hsch to modules Cornelia Huck 2019-01-30 13:22 ` [Qemu-devel] " Cornelia Huck 2019-01-30 13:22 ` [PATCH v3 6/6] vfio-ccw: add handling for async channel instructions Cornelia Huck 2019-01-30 13:22 ` [Qemu-devel] " Cornelia Huck 2019-01-30 17:00 ` Halil Pasic 2019-01-30 17:00 ` [Qemu-devel] " Halil Pasic 2019-01-30 17:09 ` Halil Pasic 2019-01-30 17:09 ` [Qemu-devel] " Halil Pasic 2019-01-31 11:53 ` Cornelia Huck 2019-01-31 11:53 ` [Qemu-devel] " Cornelia Huck 2019-02-06 14:00 ` [PATCH v3 0/6] vfio-ccw: support hsch/csch (kernel part) Cornelia Huck 2019-02-06 14:00 ` [Qemu-devel] " Cornelia Huck 2019-02-08 21:19 ` Eric Farman 2019-02-08 21:19 ` [Qemu-devel] " Eric Farman 2019-02-11 16:13 ` Cornelia Huck 2019-02-11 16:13 ` [Qemu-devel] " Cornelia Huck 2019-02-11 17:37 ` Eric Farman 2019-02-11 17:37 ` [Qemu-devel] " Eric Farman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190130132212.7376-1-cohuck@redhat.com \ --to=cohuck@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=alifm@linux.ibm.com \ --cc=farman@linux.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=pasic@linux.ibm.com \ --cc=pmorel@linux.ibm.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-s390x@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.