All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Staudt <koraktor@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Duy Nguyen <pclouds@gmail.com>,
	Sebastian Staudt <koraktor@gmail.com>
Subject: [PATCH v4 2/2] t6120: test for describe with a bare repository
Date: Fri,  1 Feb 2019 14:55:12 +0100	[thread overview]
Message-ID: <20190201135512.68220-2-koraktor@gmail.com> (raw)
In-Reply-To: <20190201135512.68220-1-koraktor@gmail.com>

This ensures that nothing breaks the basic functionality of describe for
bare repositories. Please note that --broken and --dirty need a working
tree.

Signed-off-by: Sebastian Staudt <koraktor@gmail.com>
---
 t/t6120-describe.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
index 7cfed77c52..ea2c3dbe1c 100755
--- a/t/t6120-describe.sh
+++ b/t/t6120-describe.sh
@@ -418,4 +418,9 @@ test_expect_success 'describe complains about missing object' '
 	test_must_fail git describe $ZERO_OID
 '
 
+test_expect_success 'describe works from outside repo using --git-dir' ' 
+  git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" &&
+  git --git-dir "$TRASH_DIRECTORY/bare" describe
+'
+
 test_done
-- 
2.20.1


  reply	other threads:[~2019-02-01 13:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 13:55 [PATCH v4 1/2] describe: setup working tree for --dirty Sebastian Staudt
2019-02-01 13:55 ` Sebastian Staudt [this message]
2019-02-01 18:53   ` [PATCH v4 2/2] t6120: test for describe with a bare repository Junio C Hamano
2019-02-02 10:00     ` Sebastian Staudt
2019-02-01 20:12 ` [PATCH v4 1/2] describe: setup working tree for --dirty Eric Sunshine
2019-02-02 10:04   ` Sebastian Staudt
2019-02-03  3:35     ` Eric Sunshine
2019-02-01 20:52 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201135512.68220-2-koraktor@gmail.com \
    --to=koraktor@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.