All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>
Subject: [PATCH 18/20] ASoC: xtensa: Drop superfluous PCM preallocation error checks
Date: Tue,  5 Feb 2019 20:42:19 +0100	[thread overview]
Message-ID: <20190205194221.25924-19-tiwai@suse.de> (raw)
In-Reply-To: <20190205194221.25924-1-tiwai@suse.de>

snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/xtensa/xtfpga-i2s.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c
index 503560916620..2f20a02c8d46 100644
--- a/sound/soc/xtensa/xtfpga-i2s.c
+++ b/sound/soc/xtensa/xtfpga-i2s.c
@@ -469,9 +469,9 @@ static int xtfpga_pcm_new(struct snd_soc_pcm_runtime *rtd)
 	struct snd_card *card = rtd->card->snd_card;
 	size_t size = xtfpga_pcm_hardware.buffer_bytes_max;
 
-	return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
-						     SNDRV_DMA_TYPE_DEV,
-						     card->dev, size, size);
+	snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
+					      card->dev, size, size);
+	return 0;
 }
 
 static const struct snd_pcm_ops xtfpga_pcm_ops = {
-- 
2.16.4

  parent reply	other threads:[~2019-02-05 19:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
2019-02-05 19:42 ` [PATCH 01/20] ALSA: atmel: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 02/20] ALSA: parisc: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 03/20] ALSA: pci: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 04/20] ALSA: ppc: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 05/20] ALSA: sh: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 06/20] ALSA: sparc: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 07/20] ALSA: spi: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 08/20] ALSA: usb: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 09/20] ASoC: amd: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 10/20] ASoC: dwc: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 11/20] ASoC: intel: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 12/20] ASoC: mediatek: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 13/20] ASoC: meson: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 14/20] ASoC: sh: " Takashi Iwai
2019-02-06  5:51   ` Kuninori Morimoto
2019-02-05 19:42 ` [PATCH 15/20] ASoC: stm: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 16/20] ASoC: txx9: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 17/20] ASoC: uniphier: " Takashi Iwai
2019-02-05 19:42 ` Takashi Iwai [this message]
2019-02-05 19:42 ` [PATCH 19/20] ASoC: dmaengine: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 20/20] ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void Takashi Iwai
2019-02-06  9:07 ` [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Jaroslav Kysela
2019-02-06  9:27   ` Takashi Iwai
2019-02-06 14:50   ` Mark Brown
2019-02-06 15:35     ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205194221.25924-19-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.