All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: [PATCH 5/6] drm/i915/psr: Initialize PSR mutex even when sink is not reliable
Date: Thu,  7 Feb 2019 14:24:27 -0800	[thread overview]
Message-ID: <20190207222428.16785-5-jose.souza@intel.com> (raw)
In-Reply-To: <20190207222428.16785-1-jose.souza@intel.com>

Even when driver is reload and hits this scenario the PSR mutex
should be initialized, otherwise reading PSR debugfs status will
execute mutex_lock() over a mutex that was not initialized.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 8bed73914876..086d498362b6 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -1203,7 +1203,6 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
 	if (val) {
 		DRM_DEBUG_KMS("PSR interruption error set\n");
 		dev_priv->psr.sink_not_reliable = true;
-		return;
 	}
 
 	/* Set link_standby x link_off defaults */
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-02-07 22:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 22:24 [PATCH 1/6] drm/i915: Compute has_drrs after compute has_psr José Roberto de Souza
2019-02-07 22:24 ` [PATCH 2/6] drm/i915/drrs: Disable DRRS when needed in fastsets José Roberto de Souza
2019-02-07 22:24 ` [PATCH 3/6] drm/i915/drrs: Refactor intel_dp_set_drrs_state() José Roberto de Souza
2019-02-08  5:34   ` kbuild test robot
2019-02-07 22:24 ` [PATCH 4/6] drm/i915/psr: Remove PSR2 FIXME José Roberto de Souza
2019-02-14  0:28   ` Dhinakaran Pandiyan
2019-02-07 22:24 ` José Roberto de Souza [this message]
2019-02-07 22:24 ` [PATCH 6/6] drm/i915/psr: Do not enable PSR in interlaced mode for all GENs José Roberto de Souza
2019-02-07 23:14 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Compute has_drrs after compute has_psr Patchwork
2019-02-08  2:58 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207222428.16785-5-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.