All of lore.kernel.org
 help / color / mirror / Atom feed
From: deepa.kernel at gmail.com (Deepa Dinamani)
Subject: [PATCH 1/1] selftests: fix timestamping Makefile
Date: Tue, 12 Feb 2019 19:29:32 -0800	[thread overview]
Message-ID: <20190213032932.2805-1-deepa.kernel@gmail.com> (raw)

The clean target in the makefile conflicts with the generic
kselftests lib.mk, and fails to properly remove the compiled
test programs.

Use TEST_GEN_PROGS macro to fit with lib.mk rules and
remove the conflicting and redundant clean.

Signed-off-by: Deepa Dinamani <deepa.kernel at gmail.com>
---
 tools/testing/selftests/networking/timestamping/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index 9050eeea5f5f..16ab85ba6409 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 CFLAGS += -I../../../../../usr/include
 
-TEST_GEN_FILES := hwtstamp_config rxtimestamp timestamping txtimestamp
+TEST_GEN_PROGS := hwtstamp_config rxtimestamp timestamping txtimestamp
 TEST_PROGS := txtimestamp.sh
 
 all: $(TEST_PROGS)
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
 top_srcdir = ../../../../..
 KSFT_KHDR_INSTALL := 1
 include ../../lib.mk
-
-clean:
-	rm -fr $(TEST_GEN_FILES)
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: deepa.kernel@gmail.com (Deepa Dinamani)
Subject: [PATCH 1/1] selftests: fix timestamping Makefile
Date: Tue, 12 Feb 2019 19:29:32 -0800	[thread overview]
Message-ID: <20190213032932.2805-1-deepa.kernel@gmail.com> (raw)
Message-ID: <20190213032932.RDXY84OVLIqoM1srpr1SobSoF2cWpiBwpWOZ4vjzZig@z> (raw)

The clean target in the makefile conflicts with the generic
kselftests lib.mk, and fails to properly remove the compiled
test programs.

Use TEST_GEN_PROGS macro to fit with lib.mk rules and
remove the conflicting and redundant clean.

Signed-off-by: Deepa Dinamani <deepa.kernel at gmail.com>
---
 tools/testing/selftests/networking/timestamping/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index 9050eeea5f5f..16ab85ba6409 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 CFLAGS += -I../../../../../usr/include
 
-TEST_GEN_FILES := hwtstamp_config rxtimestamp timestamping txtimestamp
+TEST_GEN_PROGS := hwtstamp_config rxtimestamp timestamping txtimestamp
 TEST_PROGS := txtimestamp.sh
 
 all: $(TEST_PROGS)
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
 top_srcdir = ../../../../..
 KSFT_KHDR_INSTALL := 1
 include ../../lib.mk
-
-clean:
-	rm -fr $(TEST_GEN_FILES)
-- 
2.17.1

             reply	other threads:[~2019-02-13  3:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13  3:29 deepa.kernel [this message]
2019-02-13  3:29 ` [PATCH 1/1] selftests: fix timestamping Makefile Deepa Dinamani
2019-02-13 14:44 ` willemdebruijn.kernel
2019-02-13 14:44   ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213032932.2805-1-deepa.kernel@gmail.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.