All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: rostedt@goodmis.org, mingo@redhat.com
Cc: will.deacon@arm.com, catalin.marinas@arm.com,
	andreyknvl@google.com, aryabinin@virtuozzo.com,
	linux-arm-kernel@lists.infradead.org, kasan-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH] trace: skip hwasan
Date: Sat, 16 Feb 2019 23:34:34 -0500	[thread overview]
Message-ID: <20190217043434.46233-1-cai@lca.pw> (raw)

Enabling function tracer with CONFIG_KASAN_SW_TAGS=y (hwasan) tracer
causes the whole system frozen on ThunderX2 systems with 256 CPUs,
because there is a burst of too much pointer access, and then KASAN will
dereference each byte of the shadow address for the tag checking which
will kill all the CPUs.

Signed-off-by: Qian Cai <cai@lca.pw>
---
 kernel/trace/Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
index c2b2148bb1d2..fdd547a68385 100644
--- a/kernel/trace/Makefile
+++ b/kernel/trace/Makefile
@@ -28,6 +28,11 @@ ifdef CONFIG_GCOV_PROFILE_FTRACE
 GCOV_PROFILE := y
 endif
 
+# Too much pointer access will kill hwasan.
+ifdef CONFIG_KASAN_SW_TAGS
+KASAN_SANITIZE := n
+endif
+
 CFLAGS_trace_benchmark.o := -I$(src)
 CFLAGS_trace_events_filter.o := -I$(src)
 
-- 
2.17.2 (Apple Git-113)


WARNING: multiple messages have this Message-ID (diff)
From: Qian Cai <cai@lca.pw>
To: rostedt@goodmis.org, mingo@redhat.com
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	Qian Cai <cai@lca.pw>,
	andreyknvl@google.com, aryabinin@virtuozzo.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] trace: skip hwasan
Date: Sat, 16 Feb 2019 23:34:34 -0500	[thread overview]
Message-ID: <20190217043434.46233-1-cai@lca.pw> (raw)

Enabling function tracer with CONFIG_KASAN_SW_TAGS=y (hwasan) tracer
causes the whole system frozen on ThunderX2 systems with 256 CPUs,
because there is a burst of too much pointer access, and then KASAN will
dereference each byte of the shadow address for the tag checking which
will kill all the CPUs.

Signed-off-by: Qian Cai <cai@lca.pw>
---
 kernel/trace/Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
index c2b2148bb1d2..fdd547a68385 100644
--- a/kernel/trace/Makefile
+++ b/kernel/trace/Makefile
@@ -28,6 +28,11 @@ ifdef CONFIG_GCOV_PROFILE_FTRACE
 GCOV_PROFILE := y
 endif
 
+# Too much pointer access will kill hwasan.
+ifdef CONFIG_KASAN_SW_TAGS
+KASAN_SANITIZE := n
+endif
+
 CFLAGS_trace_benchmark.o := -I$(src)
 CFLAGS_trace_events_filter.o := -I$(src)
 
-- 
2.17.2 (Apple Git-113)


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-02-17  4:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17  4:34 Qian Cai [this message]
2019-02-17  4:34 ` [PATCH] trace: skip hwasan Qian Cai
2019-02-17  7:30 ` Dmitry Vyukov
2019-02-17  7:30   ` Dmitry Vyukov
2019-02-18 13:27   ` Qian Cai
2019-02-18 13:27     ` Qian Cai
2019-02-18 13:56     ` Dmitry Vyukov
2019-02-18 13:56       ` Dmitry Vyukov
2019-02-18 13:59       ` Will Deacon
2019-02-18 13:59         ` Will Deacon
2019-02-21 14:19         ` James Morse
2019-02-21 14:19           ` James Morse
2019-02-18 10:43 ` Will Deacon
2019-02-18 10:43   ` Will Deacon
2019-02-18 15:25 ` Andrey Konovalov
2019-02-18 15:25   ` Andrey Konovalov
2019-02-18 15:53   ` Qian Cai
2019-02-18 15:53     ` Qian Cai
2019-02-18 15:56     ` Andrey Konovalov
2019-02-18 15:56       ` Andrey Konovalov
2019-02-18 17:23       ` Steven Rostedt
2019-02-18 17:23         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190217043434.46233-1-cai@lca.pw \
    --to=cai@lca.pw \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.