All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Kirillov <max@max630.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Cc: Max Kirillov <max@max630.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	"Randall S. Becker" <rsbecker@nexbridge.com>,
	'Junio C Hamano' <gitster@pobox.com>
Subject: [PATCH] t5562: chunked sleep to avoid lost SIGCHILD
Date: Mon, 18 Feb 2019 22:50:28 +0200	[thread overview]
Message-ID: <20190218205028.32486-1-max@max630.net> (raw)
In-Reply-To: <20190215130213.GK1622@szeder.dev>

If was found during stress-test run that a test may hang by 60 seconds.
It supposedly happens because SIGCHILD was received before sleep has
started.

Fix by looping by smaller chunks, checking $exited after each of them.
Then lost SIGCHILD would not cause longer delay than 1 second.

Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Max Kirillov <max@max630.net>
---
Submitting as proper patch. Note: I believe it does not relate to other issues
discussed in this thread.
 t/t5562/invoke-with-content-length.pl | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/t/t5562/invoke-with-content-length.pl b/t/t5562/invoke-with-content-length.pl
index 0943474af2..257e280e3b 100644
--- a/t/t5562/invoke-with-content-length.pl
+++ b/t/t5562/invoke-with-content-length.pl
@@ -29,7 +29,12 @@
 }
 print $out $body_data or die "Cannot write data: $!";
 
-sleep 60; # is interrupted by SIGCHLD
+my $counter = 0;
+while (not $exited and $counter < 60) {
+        sleep 1;
+        $counter = $counter + 1;
+}
+
 if (!$exited) {
         close($out);
         die "Command did not exit after reading whole body";
-- 
2.19.0.1202.g68e1e8f04e


  parent reply	other threads:[~2019-02-18 20:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 15:04 [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) Randall S. Becker
2019-02-14 19:56 ` Junio C Hamano
2019-02-14 21:36 ` Johannes Schindelin
2019-02-14 22:25   ` Randall S. Becker
2019-02-15 13:02   ` SZEDER Gábor
2019-02-15 13:49     ` Randall S. Becker
2019-02-15 20:37     ` Max Kirillov
2019-02-15 21:13       ` Randall S. Becker
2019-02-16  8:26         ` Max Kirillov
2019-02-18 20:50     ` Max Kirillov [this message]
2019-02-18 20:54       ` [PATCH] t5562: chunked sleep to avoid lost SIGCHILD Randall S. Becker
2019-02-18 20:59         ` Max Kirillov
2019-02-19 18:38       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218205028.32486-1-max@max630.net \
    --to=max@max630.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rsbecker@nexbridge.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.