All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: "Ben Greear" <greearb@candelatech.com>,
	"Grant Grundler" <grundler@google.com>,
	"Kalle Valo" <kvalo@codeaurora.org>,
	wgong@qti.qualcomm.com, ath10k@lists.infradead.org,
	wgong@codeaurora.org, "Johannes Berg" <johannes@sipsolutions.net>,
	"Kan Yan" <kyan@google.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7
Date: Thu, 21 Feb 2019 18:29:36 +0100	[thread overview]
Message-ID: <20190221172936.21816-1-toke@redhat.com> (raw)
In-Reply-To: <87d0nlhxl9.fsf@toke.dk>

When we did the original tests for the optimal value of sk_pacing_shift, we
came up with 6 ms of buffering as the default. Sadly, 6 is not a power of
two, so when picking the shift value I erred on the size of less buffering
and picked 4 ms instead of 8. This was probably wrong; those 2 ms of extra
buffering makes a larger difference than I thought.

So, change the default pacing shift to 7, which corresponds to 8 ms of
buffering. The point of diminishing returns really kicks in after 8 ms, and
so having this as a default should cut down on the need for extensive
per-device testing and overrides needed in the drivers.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
 net/mac80211/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index 5055aeba5c5a..800e67615e2a 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -617,13 +617,13 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,
 	 * We need a bit of data queued to build aggregates properly, so
 	 * instruct the TCP stack to allow more than a single ms of data
 	 * to be queued in the stack. The value is a bit-shift of 1
-	 * second, so 8 is ~4ms of queued data. Only affects local TCP
+	 * second, so 7 is ~8ms of queued data. Only affects local TCP
 	 * sockets.
 	 * This is the default, anyhow - drivers may need to override it
 	 * for local reasons (longer buffers, longer completion time, or
 	 * similar).
 	 */
-	local->hw.tx_sk_pacing_shift = 8;
+	local->hw.tx_sk_pacing_shift = 7;
 
 	/* set up some defaults */
 	local->hw.queues = 1;
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: "Kan Yan" <kyan@google.com>,
	wgong@qti.qualcomm.com,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	ath10k@lists.infradead.org,
	"Grant Grundler" <grundler@google.com>,
	wgong@codeaurora.org, "Ben Greear" <greearb@candelatech.com>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Kalle Valo" <kvalo@codeaurora.org>
Subject: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7
Date: Thu, 21 Feb 2019 18:29:36 +0100	[thread overview]
Message-ID: <20190221172936.21816-1-toke@redhat.com> (raw)
In-Reply-To: <87d0nlhxl9.fsf@toke.dk>

When we did the original tests for the optimal value of sk_pacing_shift, we
came up with 6 ms of buffering as the default. Sadly, 6 is not a power of
two, so when picking the shift value I erred on the size of less buffering
and picked 4 ms instead of 8. This was probably wrong; those 2 ms of extra
buffering makes a larger difference than I thought.

So, change the default pacing shift to 7, which corresponds to 8 ms of
buffering. The point of diminishing returns really kicks in after 8 ms, and
so having this as a default should cut down on the need for extensive
per-device testing and overrides needed in the drivers.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
 net/mac80211/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index 5055aeba5c5a..800e67615e2a 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -617,13 +617,13 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,
 	 * We need a bit of data queued to build aggregates properly, so
 	 * instruct the TCP stack to allow more than a single ms of data
 	 * to be queued in the stack. The value is a bit-shift of 1
-	 * second, so 8 is ~4ms of queued data. Only affects local TCP
+	 * second, so 7 is ~8ms of queued data. Only affects local TCP
 	 * sockets.
 	 * This is the default, anyhow - drivers may need to override it
 	 * for local reasons (longer buffers, longer completion time, or
 	 * similar).
 	 */
-	local->hw.tx_sk_pacing_shift = 8;
+	local->hw.tx_sk_pacing_shift = 7;
 
 	/* set up some defaults */
 	local->hw.queues = 1;
-- 
2.20.1


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2019-02-21 17:30 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 10:40 [PATCH v2 0/2] Change sk_pacing_shift in ieee80211_hw for best tx throughput Wen Gong
2018-08-08 10:40 ` Wen Gong
2018-08-08 10:40 ` [PATCH v2 1/2] mac80211: Change sk_pacing_shift saved to ieee80211_hw Wen Gong
2018-08-08 10:40   ` Wen Gong
2018-08-08 10:40 ` [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips Wen Gong
2018-08-08 10:40   ` Wen Gong
2018-08-08 10:43   ` Toke Høiland-Jørgensen
2018-08-08 10:43     ` Toke Høiland-Jørgensen
2018-08-10  8:05     ` Wen Gong
2018-08-10  8:05       ` Wen Gong
2018-08-10 13:17       ` Toke Høiland-Jørgensen
2018-08-10 13:17         ` Toke Høiland-Jørgensen
2018-08-13  5:37         ` Wen Gong
2018-08-13  5:37           ` Wen Gong
2018-08-13 11:18           ` Toke Høiland-Jørgensen
2018-08-13 11:18             ` Toke Høiland-Jørgensen
2018-08-14  5:55             ` Wen Gong
2018-08-14  5:55               ` Wen Gong
2018-08-17 11:32               ` Toke Høiland-Jørgensen
2018-08-17 11:32                 ` Toke Høiland-Jørgensen
2018-08-30 23:25                 ` Peter Oh
2018-08-30 23:25                   ` Peter Oh
2018-08-31 15:36                   ` Toke Høiland-Jørgensen
2018-08-31 15:36                     ` Toke Høiland-Jørgensen
2018-08-30 23:32           ` Grant Grundler
2018-09-03  9:38             ` Johannes Berg
2018-09-03  9:38               ` Johannes Berg
2018-09-03 11:11               ` Toke Høiland-Jørgensen
2018-09-03 11:11                 ` Toke Høiland-Jørgensen
2018-09-03 11:47                 ` Johannes Berg
2018-09-03 11:47                   ` Johannes Berg
2018-09-03 13:35                   ` Toke Høiland-Jørgensen
2018-09-03 13:35                     ` Toke Høiland-Jørgensen
2018-09-03 14:57                     ` Dave Taht
2018-09-03 14:57                       ` Dave Taht
2018-09-03 15:35                       ` Dave Taht
2018-09-03 15:35                         ` Dave Taht
2018-09-04 23:43                     ` Grant Grundler
2018-09-04 23:43                       ` Grant Grundler
2018-09-05  7:23                       ` Wen Gong
2018-09-05  7:23                         ` Wen Gong
2018-09-06 10:18                       ` Toke Høiland-Jørgensen
2018-09-06 10:18                         ` Toke Høiland-Jørgensen
2019-02-20 19:15                         ` Grant Grundler
2019-02-20 19:15                           ` Grant Grundler
2019-02-21  4:39                           ` Kalle Valo
2019-02-21  4:39                             ` Kalle Valo
2019-02-21 15:42                           ` Toke Høiland-Jørgensen
2019-02-21 15:42                             ` Toke Høiland-Jørgensen
2019-02-21 16:10                             ` Kalle Valo
2019-02-21 16:10                               ` Kalle Valo
2019-02-21 16:22                               ` Ben Greear
2019-02-21 16:22                                 ` Ben Greear
2019-02-21 16:37                                 ` Toke Høiland-Jørgensen
2019-02-21 16:37                                   ` Toke Høiland-Jørgensen
2019-02-21 16:57                                   ` Ben Greear
2019-02-21 16:57                                     ` Ben Greear
2019-02-21 17:15                                     ` Toke Høiland-Jørgensen
2019-02-21 17:15                                       ` Toke Høiland-Jørgensen
2019-02-21 17:29                                       ` Toke Høiland-Jørgensen [this message]
2019-02-21 17:29                                         ` [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 Toke Høiland-Jørgensen
2019-02-22 12:29                                         ` Johannes Berg
2019-02-22 13:06                                           ` Toke Høiland-Jørgensen
2019-02-22 13:06                                             ` Toke Høiland-Jørgensen
2019-02-22 13:07                                             ` Johannes Berg
2019-02-22 13:07                                               ` Johannes Berg
2019-02-22 13:40                                               ` Toke Høiland-Jørgensen
2019-02-22 13:40                                                 ` Toke Høiland-Jørgensen
2019-02-22 19:10                                                 ` Johannes Berg
2019-02-22 19:10                                                   ` Johannes Berg
2019-02-23 11:49                                                   ` Toke Høiland-Jørgensen
2019-02-23 11:49                                                     ` Toke Høiland-Jørgensen
2019-02-21 17:29                                       ` [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips Ben Greear
2019-02-21 17:29                                         ` Ben Greear
2019-02-21 22:50                                         ` Toke Høiland-Jørgensen
2019-02-21 22:50                                           ` Toke Høiland-Jørgensen
2019-02-21 16:28                               ` Toke Høiland-Jørgensen
2019-02-21 16:28                                 ` Toke Høiland-Jørgensen
2020-04-23  6:31   ` Kalle Valo
2020-04-23  6:31   ` Kalle Valo
2018-08-08 19:00 ` [PATCH v2 0/2] Change sk_pacing_shift in ieee80211_hw for best tx throughput Peter Oh
2018-08-08 19:00   ` Peter Oh
2018-08-09  9:32   ` Arend van Spriel
2018-08-09  9:32     ` Arend van Spriel
2018-08-10 13:20     ` Toke Høiland-Jørgensen
2018-08-10 13:20       ` Toke Høiland-Jørgensen
2018-08-10 19:28       ` Arend van Spriel
2018-08-10 19:28         ` Arend van Spriel
2018-08-10 19:52         ` Ben Greear
2018-08-10 19:52           ` Ben Greear
2018-08-11 19:21           ` Arend van Spriel
2018-08-11 19:21             ` Arend van Spriel
2018-08-20 12:46             ` Toke Høiland-Jørgensen
2018-08-20 12:46               ` Toke Høiland-Jørgensen
2018-08-20 15:14               ` Ben Greear
2018-08-20 15:14                 ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190221172936.21816-1-toke@redhat.com \
    --to=toke@redhat.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=grundler@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=kyan@google.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    --cc=wgong@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.