All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: linux-pm@vger.kernel.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-imx@nxp.com, linux-kernel@vger.kernel.org
Subject: [PATCH v2 02/13] thermal: qoriq: Remove unnecessary DT node is NULL check
Date: Fri, 22 Feb 2019 12:04:57 -0800	[thread overview]
Message-ID: <20190222200508.26325-3-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190222200508.26325-1-andrew.smirnov@gmail.com>

This driver is meant to be used with Device Tree and there's no
use-case where device's DT node is going to be NULL. Remove code
protecting against that.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-imx@nxp.com
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/thermal/qoriq_thermal.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index 3b5f5b3fb1bc..7b364933bfb1 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -193,11 +193,6 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
 	struct qoriq_tmu_data *data;
 	struct device_node *np = pdev->dev.of_node;
 
-	if (!np) {
-		dev_err(&pdev->dev, "Device OF-Node is NULL");
-		return -ENODEV;
-	}
-
 	data = devm_kzalloc(&pdev->dev, sizeof(struct qoriq_tmu_data),
 			    GFP_KERNEL);
 	if (!data)
-- 
2.20.1


  parent reply	other threads:[~2019-02-22 20:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 20:04 [PATCH v2 00/13] QorIQ TMU multi-sensor and HWMON support Andrey Smirnov
2019-02-22 20:04 ` [PATCH v2 01/13] thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs() Andrey Smirnov
2019-02-22 20:04 ` Andrey Smirnov [this message]
2019-02-22 20:04 ` [PATCH v2 03/13] thermal: qoriq: Add local struct device pointer Andrey Smirnov
2019-02-22 20:04 ` [PATCH v2 04/13] thermal: qoriq: Don't store struct thermal_zone_device reference Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 05/13] thermal: qoriq: Add local struct qoriq_sensor pointer Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 06/13] thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 07/13] thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 08/13] thermal: qoriq: Pass data to qoriq_tmu_calibration() directly Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 09/13] thermal: qoriq: Convert driver to use devm_ioremap() Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 10/13] thermal: qoriq: Convert driver to use regmap API Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 11/13] thermal: qoriq: Enable all sensors before registering them Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 12/13] thermal: qoriq: Do not report invalid temperature reading Andrey Smirnov
2019-02-22 20:05 ` [PATCH v2 13/13] thermal: qoriq: Add hwmon support Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222200508.26325-3-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.