All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Roman Bolshakov <r.bolshakv@yadro.com>,
	BALATON Zoltan <balaton@eik.bme.hu>,
	John Arbuckle <programmingkidx@gmail.com>,
	Berkus Decker <berkus@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Ben Hekster <ben.hekster@foghorn.io>
Subject: [Qemu-devel] [PATCH v3 6/7] ui/cocoa: Subclass NSApplication so we can implement sendEvent
Date: Mon, 25 Feb 2019 10:24:32 +0000	[thread overview]
Message-ID: <20190225102433.22401-7-peter.maydell@linaro.org> (raw)
In-Reply-To: <20190225102433.22401-1-peter.maydell@linaro.org>

When we switch away from our custom event handling, we still want to
be able to have first go at any events our application receives,
because in full-screen mode we want to send key events to the guest,
even if they would be menu item activation events. There are several
ways we could do that, but one simple approach is to subclass
NSApplication so we can implement a custom sendEvent method.
Do that, but for the moment have our sendEvent just invoke the
superclass method.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Tested-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-id: 20190214102816.3393-7-peter.maydell@linaro.org
---
 ui/cocoa.m | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 1b54d42aba..00e3db69c9 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1482,6 +1482,17 @@ - (void)adjustSpeed:(id)sender
 
 @end
 
+@interface QemuApplication : NSApplication
+@end
+
+@implementation QemuApplication
+- (void)sendEvent:(NSEvent *)event
+{
+    COCOA_DEBUG("QemuApplication: sendEvent\n");
+    [super sendEvent: event];
+}
+@end
+
 static void create_initial_menus(void)
 {
     // Add menus
@@ -1695,7 +1706,7 @@ int main (int argc, const char * argv[]) {
     ProcessSerialNumber psn = { 0, kCurrentProcess };
     TransformProcessType(&psn, kProcessTransformToForegroundApplication);
 
-    [NSApplication sharedApplication];
+    [QemuApplication sharedApplication];
 
     create_initial_menus();
 
-- 
2.17.2 (Apple Git-113)

  parent reply	other threads:[~2019-02-25 10:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 10:24 [Qemu-devel] [PATCH v3 0/7] ui/cocoa: Use OSX's main loop Peter Maydell
2019-02-25 10:24 ` [Qemu-devel] [PATCH v3 1/7] ui/cocoa: Ensure we have the iothread lock when calling into QEMU Peter Maydell
2019-02-28 21:53   ` G 3
2019-03-01  9:47     ` Peter Maydell
2019-02-25 10:24 ` [Qemu-devel] [PATCH v3 2/7] ui/cocoa: Use the pixman image directly in switchSurface Peter Maydell
2019-02-25 10:24 ` [Qemu-devel] [PATCH v3 3/7] ui/cocoa: Factor out initial menu creation Peter Maydell
2019-02-25 10:24 ` [Qemu-devel] [PATCH v3 4/7] ui/cocoa: Move console/device menu creation code up in file Peter Maydell
2019-02-25 10:24 ` [Qemu-devel] [PATCH v3 5/7] ui/cocoa: Don't call NSApp sendEvent directly from handleEvent Peter Maydell
2019-02-25 10:24 ` Peter Maydell [this message]
2019-02-25 10:24 ` [Qemu-devel] [PATCH v3 7/7] ui/cocoa: Perform UI operations only on the main thread Peter Maydell
2019-02-28 22:35   ` G 3
2019-02-25 10:28 ` [Qemu-devel] [PATCH v3 0/7] ui/cocoa: Use OSX's main loop Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225102433.22401-7-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=balaton@eik.bme.hu \
    --cc=ben.hekster@foghorn.io \
    --cc=berkus@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=patches@linaro.org \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakv@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.