From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Eric Anholt <eric@anholt.net>, stable@vger.kernel.org Subject: [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset. Date: Fri, 1 Mar 2019 13:56:11 +0100 [thread overview] Message-ID: <20190301125627.7285-2-maarten.lankhorst@linux.intel.com> (raw) In-Reply-To: <20190301125627.7285-1-maarten.lankhorst@linux.intel.com> __drm_atomic_helper_crtc_destroy_state does not free memory, it only cleans it up. Fix this by calling the functions own destroy function. Fixes: 6d6e50039187 ("drm/vc4: Allocate the right amount of space for boot-time CRTC state.") Cc: Eric Anholt <eric@anholt.net> Cc: <stable@vger.kernel.org> # v4.6+ Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 730008d3da76..e7c04a9eb219 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -1042,7 +1042,7 @@ static void vc4_crtc_reset(struct drm_crtc *crtc) { if (crtc->state) - __drm_atomic_helper_crtc_destroy_state(crtc->state); + vc4_crtc_destroy_state(crtc->state); crtc->state = kzalloc(sizeof(struct vc4_crtc_state), GFP_KERNEL); if (crtc->state) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset. Date: Fri, 1 Mar 2019 13:56:11 +0100 [thread overview] Message-ID: <20190301125627.7285-2-maarten.lankhorst@linux.intel.com> (raw) In-Reply-To: <20190301125627.7285-1-maarten.lankhorst@linux.intel.com> __drm_atomic_helper_crtc_destroy_state does not free memory, it only cleans it up. Fix this by calling the functions own destroy function. Fixes: 6d6e50039187 ("drm/vc4: Allocate the right amount of space for boot-time CRTC state.") Cc: Eric Anholt <eric@anholt.net> Cc: <stable@vger.kernel.org> # v4.6+ Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 730008d3da76..e7c04a9eb219 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -1042,7 +1042,7 @@ static void vc4_crtc_reset(struct drm_crtc *crtc) { if (crtc->state) - __drm_atomic_helper_crtc_destroy_state(crtc->state); + vc4_crtc_destroy_state(crtc->state); crtc->state = kzalloc(sizeof(struct vc4_crtc_state), GFP_KERNEL); if (crtc->state) -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-01 13:03 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-01 12:56 [PATCH 00/17] drm: Start subclassing crtc_state Maarten Lankhorst 2019-03-01 12:56 ` Maarten Lankhorst [this message] 2019-03-01 12:56 ` [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset Maarten Lankhorst 2019-03-01 22:43 ` Eric Anholt 2019-03-01 22:43 ` Eric Anholt 2019-03-01 12:56 ` [PATCH 02/17] drm/atomic: Create __drm_atomic_helper_crtc_reset() for subclassing crtc_state Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 03/17] drm/docs: Fix typo in __drm_atomic_helper_connector_reset Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 04/17] drm/amd: Convert to using __drm_atomic_helper_crtc_reset() for reset Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 05/17] drm/mali: " Maarten Lankhorst 2019-03-01 13:37 ` Liviu Dudau 2019-03-01 12:56 ` [PATCH 06/17] drm/atmel-hlcdc: " Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 07/17] drm/i915: Use the new __drm_atomic_helper_crtc_reset() helper Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 08/17] drm/imx: Convert to using __drm_atomic_helper_crtc_reset() for reset Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 09/17] drm/mediatek: " Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 10/17] drm/msm: " Maarten Lankhorst 2019-03-04 19:23 ` Sean Paul 2019-03-01 12:56 ` [PATCH 11/17] drm/omap: " Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 12/17] drm/rcar-du: " Maarten Lankhorst 2019-03-01 12:56 ` Maarten Lankhorst 2019-03-01 13:13 ` Laurent Pinchart 2019-03-01 13:13 ` Laurent Pinchart 2019-03-01 14:08 ` Maarten Lankhorst 2019-03-01 14:08 ` Maarten Lankhorst 2019-03-01 14:36 ` Laurent Pinchart 2019-03-01 14:36 ` Laurent Pinchart 2019-03-01 14:47 ` Maarten Lankhorst 2019-03-01 14:47 ` Maarten Lankhorst 2019-03-01 15:06 ` Laurent Pinchart 2019-03-01 15:06 ` Laurent Pinchart [not found] ` <20190301125627.7285-1-maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2019-03-01 12:56 ` [PATCH 13/17] drm/rockchip: " Maarten Lankhorst 2019-03-18 18:07 ` Heiko Stübner 2019-03-01 12:56 ` [PATCH 14/17] drm/tegra: " Maarten Lankhorst 2019-03-04 13:02 ` Thierry Reding 2019-03-01 12:56 ` [PATCH 15/17] drm/vc4: " Maarten Lankhorst 2019-03-01 22:47 ` Eric Anholt 2019-03-04 13:51 ` Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 16/17] drm/vkms: " Maarten Lankhorst 2019-03-06 22:43 ` Rodrigo Siqueira 2019-04-25 9:41 ` Maarten Lankhorst 2019-03-01 12:56 ` [PATCH 17/17] drm/vmwgfx: " Maarten Lankhorst 2019-03-01 13:23 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Start subclassing crtc_state Patchwork 2019-03-01 13:27 ` ✗ Fi.CI.SPARSE: " Patchwork 2019-03-01 13:45 ` ✓ Fi.CI.BAT: success " Patchwork 2019-03-01 17:03 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190301125627.7285-2-maarten.lankhorst@linux.intel.com \ --to=maarten.lankhorst@linux.intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=intel-gfx@lists.freedesktop.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.